You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/29 14:45:50 UTC
[GitHub] [superset] diegomedina248 opened a new pull request, #19898: feature: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed
diegomedina248 opened a new pull request, #19898:
URL: https://github.com/apache/superset/pull/19898
### SUMMARY
This PR adjusts the metrics popover in Explore to:
* When editing the title, hitting enter should save the title as well
* Adjust the size of the view & edit modes so that they take the same height and prevent the popover from changing positions
Additionally, took the opportunity to:
* Refactor the file involved to use typescript
* Refactor the tests to use react testing library instead, and added more tests scenarios
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not a visual change to see, so no before/after:
https://user-images.githubusercontent.com/17252075/165967447-5d9d76c5-b3bc-4d93-ba33-eee8b5cb80a6.mov
### TESTING INSTRUCTIONS
Explore a chart, try to edit a metric and ensure the title gets saved on enter.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19898: feat: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #19898:
URL: https://github.com/apache/superset/pull/19898#discussion_r865340413
##########
superset-frontend/src/assets/stylesheets/superset.less:
##########
@@ -518,9 +518,14 @@ tr.reactable-column-header th.reactable-header-sortable {
padding-right: 17px;
}
+.metric-edit-popover-label {
+ display: inline-block;
+ padding: 2px 0;
+}
+
.metric-edit-popover-label-input {
border-radius: @border-radius-large;
- height: 30px;
+ height: 26px;
Review Comment:
Would it be possible to move both these classes to Emotion styling in the component? We're trying to whittle away at these LESS files so that we can use variables from the Superset theme everywhere (e.g. using the `gridUnit` and `borderRadius` keys from the theme)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #19898: feat: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed
Posted by GitBox <gi...@apache.org>.
rusackas merged PR #19898:
URL: https://github.com/apache/superset/pull/19898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19898: feat: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19898:
URL: https://github.com/apache/superset/pull/19898#issuecomment-1113452340
# [Codecov](https://codecov.io/gh/apache/superset/pull/19898?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19898](https://codecov.io/gh/apache/superset/pull/19898?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (839cc8a) into [master](https://codecov.io/gh/apache/superset/commit/9328053521830af7f94521897e50c76ecb15933b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9328053) will **increase** coverage by `0.01%`.
> The diff coverage is `88.00%`.
```diff
@@ Coverage Diff @@
## master #19898 +/- ##
==========================================
+ Coverage 66.52% 66.53% +0.01%
==========================================
Files 1714 1714
Lines 65032 65032
Branches 6717 6718 +1
==========================================
+ Hits 43260 43267 +7
+ Misses 20065 20059 -6
+ Partials 1707 1706 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.27% <88.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rols/MetricControl/AdhocMetricEditPopoverTitle.tsx](https://codecov.io/gh/apache/superset/pull/19898/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXJUaXRsZS50c3g=) | `88.00% <88.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19898?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19898?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9328053...839cc8a](https://codecov.io/gh/apache/superset/pull/19898?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org