You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/01 11:52:55 UTC

[GitHub] [flink-kubernetes-operator] gaborgsomogyi opened a new pull request, #459: [FLINK-29974] Allow session job cancel to be called for each job state

gaborgsomogyi opened a new pull request, #459:
URL: https://github.com/apache/flink-kubernetes-operator/pull/459

   ## What is the purpose of the change
   
   When session jobs are in a specific states and cancel called they throw exceptions. In this PR I've added test for each state and changed the code to handle states correctly.
   
   ## Brief change log
   
   * Allow session job cancel to be called for each job state
   * Minor refactor in the app cancel area
   
   ## Verifying this change
   Existing + additional unit tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #459: [FLINK-29974] Allow session job cancel to be called for each job state

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #459:
URL: https://github.com/apache/flink-kubernetes-operator/pull/459#issuecomment-1335078501

   Rebased to the latest master to fix the e2e issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #459: [FLINK-29974] Allow session job cancel to be called for each job state

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #459:
URL: https://github.com/apache/flink-kubernetes-operator/pull/459#issuecomment-1333650021

   cc @gyfora 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #459: [FLINK-29974] Allow session job cancel to be called for each job state

Posted by GitBox <gi...@apache.org>.
mbalassi merged PR #459:
URL: https://github.com/apache/flink-kubernetes-operator/pull/459


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org