You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/10/01 17:43:07 UTC

[jira] [Created] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Harsh J created MAPREDUCE-4695:
----------------------------------

             Summary: Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
                 Key: MAPREDUCE-4695
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
             Project: Hadoop Map/Reduce
          Issue Type: Bug
    Affects Versions: 3.0.0
            Reporter: Harsh J
            Assignee: Harsh J
            Priority: Blocker


MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.

{code}
mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
{code}

All local job tests have been failing since then.

This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466915#comment-13466915 ] 

Harsh J commented on MAPREDUCE-4695:
------------------------------------

So far things seem to be passing at: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2895/console

Will commit this fix (minus dummy forced changes) and open a new JIRA to see what we ought to do about that parameter name as it has "cluster" in it and only LocalRunner uses it anymore per my greps. But the property can stay and continue to be harmless for now.

{code}
Running org.apache.hadoop.mapreduce.TestLocalRunner
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.904 sec
{code}
                
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>         Attachments: MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466922#comment-13466922 ] 

Robert Joseph Evans commented on MAPREDUCE-4695:
------------------------------------------------

The patch looks good. I don't think that ClientServiceDelegate.java needs to be changed at all.

It would also be nice to add in a test so that changes like this don't break it again in the future, but I am not sure how easy that would be so I am OK without it.
                
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>         Attachments: MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466962#comment-13466962 ] 

Hudson commented on MAPREDUCE-4695:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2860 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2860/])
    MAPREDUCE-4695. Fix LocalRunner on trunk after MAPREDUCE-3223 broke it. Contributed by Harsh J. (harsh) (Revision 1392446)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1392446
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml

                
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>             Fix For: 3.0.0
>
>         Attachments: MAPREDUCE-4695.patch, MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated MAPREDUCE-4695:
-------------------------------

    Attachment: MAPREDUCE-4695.patch

Here is a fix patch (not for commit) reintroducing that parameter as before, with a dummy change in the jobclient package to enforce tests.

When committing, I'll post another patch minus the dummy changes.
                
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>         Attachments: MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466955#comment-13466955 ] 

Hadoop QA commented on MAPREDUCE-4695:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12547236/MAPREDUCE-4695.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2896//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2896//console

This message is automatically generated.
                
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>             Fix For: 3.0.0
>
>         Attachments: MAPREDUCE-4695.patch, MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466935#comment-13466935 ] 

Hadoop QA commented on MAPREDUCE-4695:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12547227/MAPREDUCE-4695.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2895//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2895//console

This message is automatically generated.
                
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>         Attachments: MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467687#comment-13467687 ] 

Hudson commented on MAPREDUCE-4695:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk #1183 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1183/])
    MAPREDUCE-4695. Fix LocalRunner on trunk after MAPREDUCE-3223 broke it. Contributed by Harsh J. (harsh) (Revision 1392446)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1392446
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml

                
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>             Fix For: 3.0.0
>
>         Attachments: MAPREDUCE-4695.patch, MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466959#comment-13466959 ] 

Hudson commented on MAPREDUCE-4695:
-----------------------------------

Integrated in Hadoop-Common-trunk-Commit #2797 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2797/])
    MAPREDUCE-4695. Fix LocalRunner on trunk after MAPREDUCE-3223 broke it. Contributed by Harsh J. (harsh) (Revision 1392446)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1392446
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml

                
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>             Fix For: 3.0.0
>
>         Attachments: MAPREDUCE-4695.patch, MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated MAPREDUCE-4695:
-------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)
    
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>             Fix For: 3.0.0
>
>         Attachments: MAPREDUCE-4695.patch, MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467702#comment-13467702 ] 

Hudson commented on MAPREDUCE-4695:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #1214 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1214/])
    MAPREDUCE-4695. Fix LocalRunner on trunk after MAPREDUCE-3223 broke it. Contributed by Harsh J. (harsh) (Revision 1392446)

     Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1392446
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml

                
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>             Fix For: 3.0.0
>
>         Attachments: MAPREDUCE-4695.patch, MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated MAPREDUCE-4695:
-------------------------------

    Status: Patch Available  (was: Open)
    
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>         Attachments: MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated MAPREDUCE-4695:
-------------------------------

    Attachment: MAPREDUCE-4695.patch

bq. The patch looks good. I don't think that ClientServiceDelegate.java needs to be changed at all.

Thats my dummy change to trigger tests in jobclient (tests reside there, while default xml is in core, a problem we've yet to fix, will follow up on this afterwards). It won't go into the final patch.

bq. It would also be nice to add in a test so that changes like this don't break it again in the future, but I am not sure how easy that would be so I am OK without it.

If we moved all tests to their right module we wouldn't have this issue (i.e. we won't miss it in pre commit builds).

Thanks Robert, I'll commit this in (new patch minus jobclient package change).
                
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>         Attachments: MAPREDUCE-4695.patch, MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4695) Fix LocalRunner on trunk after MAPREDUCE-3223 broke it

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467017#comment-13467017 ] 

Hudson commented on MAPREDUCE-4695:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2819 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2819/])
    MAPREDUCE-4695. Fix LocalRunner on trunk after MAPREDUCE-3223 broke it. Contributed by Harsh J. (harsh) (Revision 1392446)

     Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1392446
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml

                
> Fix LocalRunner on trunk after MAPREDUCE-3223 broke it
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4695
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4695
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Blocker
>             Fix For: 3.0.0
>
>         Attachments: MAPREDUCE-4695.patch, MAPREDUCE-4695.patch
>
>
> MAPREDUCE-3223 removed mapreduce.cluster.local.dir property from mapred-default.xml (since NM local dirs are now used) but failed to counter that LocalJobRunner, etc. still use it.
> {code}
> mr-3223.txt:-  <name>mapreduce.cluster.local.dir</name>
> mr-3223.txt--  <value>${hadoop.tmp.dir}/mapred/local</value>
> {code}
> All local job tests have been failing since then.
> This JIRA is to reintroduce it or provide an equivalent new config for fixing it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira