[GitHub] [superset] betodealmeida commented on a change in pull request #16859: fix: Fix Uniqueness check before update for Sqllab Overwrites

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #16859:
URL: https://github.com/apache/superset/pull/16859#discussion_r717008867



##########
File path: superset/connectors/sqla/models.py
##########
@@ -1673,7 +1673,7 @@ def before_update(
 
         if not DatasetDAO.validate_uniqueness(
             target.database_id, target.schema, target.table_name
-        ):
+        ) and hasattr(target, "columns"):

Review comment:
       I think we need to understand the problem better.
   
   Why is the backend checking for uniqueness when **updating** columns in a dataset? If `database_id`, `schema` and `table_name` didn't change then we should have exited in line 1672. Are any of those attributes changing when overwriting a dataset from SQL Lab?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org