You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/10/28 07:31:38 UTC

[GitHub] [incubator-ratis] amaliujia commented on a change in pull request #234: RATIS-1108. Add SupportedDataStreamType.DISABLED

amaliujia commented on a change in pull request #234:
URL: https://github.com/apache/incubator-ratis/pull/234#discussion_r513229302



##########
File path: ratis-server/src/main/java/org/apache/ratis/server/impl/DataStreamServerImpl.java
##########
@@ -35,31 +37,38 @@
 public class DataStreamServerImpl implements DataStreamServer {
   public static final Logger LOG = LoggerFactory.getLogger(DataStreamServerImpl.class);
 
-  private final DataStreamServerRpc serverRpc;
+  private Optional<DataStreamServerRpc> serverRpc;

Review comment:
       Thanks! 
   
   :) somehow I thought this approach complicates the code too much but I was wrong. This approach encapsulates code much well thus simplify the code.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org