[GitHub] [arrow] felipecrv commented on a diff in pull request #37380: MINOR: [C++][Python] [Docs] clearer description of q argument of quantiles

["felipecrv (via GitHub)" <gi...@apache.org>]

felipecrv commented on code in PR #37380:
URL: https://github.com/apache/arrow/pull/37380#discussion_r1313272622


##########
python/pyarrow/_compute.pyx:
##########
@@ -2145,7 +2145,8 @@ class QuantileOptions(_QuantileOptions):
     Parameters
     ----------
     q : double or sequence of double, default 0.5
-        Quantiles to compute. All values must be in [0, 1].
+        Probability levels of the quantiles to compute. All values must be in

Review Comment:
   This change seems to make a lot of sense to you, so I won’t oppose it based on a weak sense that it doesn’t make the meaning less ambiguous. 



##########
python/pyarrow/_compute.pyx:
##########
@@ -2145,7 +2145,8 @@ class QuantileOptions(_QuantileOptions):
     Parameters
     ----------
     q : double or sequence of double, default 0.5
-        Quantiles to compute. All values must be in [0, 1].
+        Probability levels of the quantiles to compute. All values must be in

Review Comment:
   This change seems to make a lot of sense to you, so I won’t oppose it based on a weak sense that it doesn’t make the meaning less ambiguous. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org