You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "Arsnael (via GitHub)" <gi...@apache.org> on 2025/02/06 04:37:22 UTC
[PR] JAMES-3525 SMTP submission should forbid sending emails with MimeMess… [james-project]
Arsnael opened a new pull request, #2630:
URL: https://github.com/apache/james-project/pull/2630
…age From header missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3525 SMTP submission should forbid sending emails with MimeMess… [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa merged PR #2630:
URL: https://github.com/apache/james-project/pull/2630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3525 SMTP submission should forbid sending emails with MimeMess… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2630:
URL: https://github.com/apache/james-project/pull/2630#issuecomment-2638807400
Not 100% sure as I hope it aint messing with some relaxation that was made for some issues on smtp submissions in the past, but let me know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3525 SMTP submission should forbid sending emails with MimeMess… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #2630:
URL: https://github.com/apache/james-project/pull/2630#discussion_r1944084280
##########
server/testing/src/main/java/org/apache/james/utils/SMTPMessageSender.java:
##########
@@ -138,11 +138,12 @@ public SMTPMessageSender sendMessageWithHeaders(String from, List<String> recipi
return this;
}
- public SMTPMessageSender sendMessageNoSender(String recipient) throws IOException {
+ public SMTPMessageSender sendMessageNoSender(String from, String recipient) throws IOException {
doHelo();
doSetSender("");
doAddRcpt(recipient);
- doData("subject: test\r\n" +
+ doData("FROM: " + from + "\r\n" +
Review Comment:
Added FROM header as we testing I believe here missing sender in the envelope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-3525 SMTP submission should forbid sending emails with MimeMess… [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #2630:
URL: https://github.com/apache/james-project/pull/2630#discussion_r1944083899
##########
server/mailet/integration-testing/src/test/java/org/apache/james/smtp/SmtpIdentityVerificationTest.java:
##########
@@ -334,23 +334,24 @@ void shouldAcceptGroupWhenOnlyUser(@TempDir File temporaryFolder) throws Excepti
}
@Test
- void errorsShouldBeIgnoredWhenUnAuthed(@TempDir File temporaryFolder) throws Exception {
Review Comment:
Removed this test as the From header was empty.
I think `shouldAcceptInvalidFromWhenUnauthenticated` test with from: INVALID covers this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org