You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Erik Selin <er...@jadedpixel.com> on 2013/08/18 18:15:06 UTC
Review Request 13635: SQOOP-1176: Added support for storing imported data as
json.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13635/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: https://issues.apache.org/jira/browse/SQOOP-1176
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1176
Repository: sqoop-trunk
Description
-------
Adding support for storing imported data as JSON.
Diffs
-----
ivy.xml d7486e0
src/java/org/apache/sqoop/SqoopOptions.java 01805f9
src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 0eca991
src/java/org/apache/sqoop/tool/ImportTool.java fbbde1d
Diff: https://reviews.apache.org/r/13635/diff/
Testing
-------
Thanks,
Erik Selin
Re: Review Request 13635: SQOOP-1176: Added support for storing imported
data as json.
Posted by Erik Selin <er...@jadedpixel.com>.
> On Sept. 11, 2013, 8:32 p.m., Erik Selin wrote:
> > src/java/org/apache/sqoop/orm/ClassWriter.java, line 841
> > <https://reviews.apache.org/r/13635/diff/3/?file=350922#file350922line841>
> >
> > Since I think it's impossible to get timezones here I defaulted to this format. I'm considering adding a -0:00 timezone just for really solid iso8601 compliance (particularly for joda DateTime compatibility). Thoughts?
this might not be the right place to correct this, but im not sure if I want to deal with it here or let user applications have to deal with it. Stuff like Joda would load this with default timezones of the box its running on which is less then ideal... :/
- Erik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13635/#review26040
-----------------------------------------------------------
On Sept. 11, 2013, 8:18 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13635/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2013, 8:18 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1176
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1176
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adding support for storing imported data as JSON.
>
>
> Diffs
> -----
>
> ivy.xml d7486e0
> src/java/org/apache/sqoop/SqoopOptions.java 01805f9
> src/java/org/apache/sqoop/orm/ClassWriter.java 0adc718
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java e02a93b
> src/test/com/cloudera/sqoop/TestJsonImport.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13635/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>
Re: Review Request 13635: SQOOP-1176: Added support for storing imported
data as json.
Posted by Erik Selin <er...@jadedpixel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13635/#review26040
-----------------------------------------------------------
src/java/org/apache/sqoop/orm/ClassWriter.java
<https://reviews.apache.org/r/13635/#comment50837>
Since I think it's impossible to get timezones here I defaulted to this format. I'm considering adding a -0:00 timezone just for really solid iso8601 compliance (particularly for joda DateTime compatibility). Thoughts?
- Erik Selin
On Sept. 11, 2013, 8:18 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13635/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2013, 8:18 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1176
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1176
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adding support for storing imported data as JSON.
>
>
> Diffs
> -----
>
> ivy.xml d7486e0
> src/java/org/apache/sqoop/SqoopOptions.java 01805f9
> src/java/org/apache/sqoop/orm/ClassWriter.java 0adc718
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java e02a93b
> src/test/com/cloudera/sqoop/TestJsonImport.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13635/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>
Re: Review Request 13635: SQOOP-1176: Added support for storing imported
data as json.
Posted by Erik Selin <er...@jadedpixel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13635/
-----------------------------------------------------------
(Updated Sept. 11, 2013, 8:18 p.m.)
Review request for Sqoop.
Changes
-------
Added tests, tweaked timestamp to be iso8601, renamed to-json -> to.json and stuffz.
Bugs: https://issues.apache.org/jira/browse/SQOOP-1176
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1176
Repository: sqoop-trunk
Description
-------
Adding support for storing imported data as JSON.
Diffs (updated)
-----
ivy.xml d7486e0
src/java/org/apache/sqoop/SqoopOptions.java 01805f9
src/java/org/apache/sqoop/orm/ClassWriter.java 0adc718
src/java/org/apache/sqoop/tool/BaseSqoopTool.java e02a93b
src/test/com/cloudera/sqoop/TestJsonImport.java PRE-CREATION
Diff: https://reviews.apache.org/r/13635/diff/
Testing
-------
Thanks,
Erik Selin
Re: Review Request 13635: SQOOP-1176: Added support for storing imported
data as json.
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13635/#review25982
-----------------------------------------------------------
Thanks for working on this. I have a small nit noted below. Also, can you please add tests?
Thanks
src/java/org/apache/sqoop/SqoopOptions.java
<https://reviews.apache.org/r/13635/#comment50731>
You may want to name the property to.json consistent with others
- Venkat Ranganathan
On Sept. 9, 2013, 1:01 a.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13635/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 1:01 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1176
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1176
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adding support for storing imported data as JSON.
>
>
> Diffs
> -----
>
> ivy.xml d7486e0
> src/java/org/apache/sqoop/SqoopOptions.java 01805f9
> src/java/org/apache/sqoop/orm/ClassWriter.java 7fdf434
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java e02a93b
>
> Diff: https://reviews.apache.org/r/13635/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>
Re: Review Request 13635: SQOOP-1176: Added support for storing imported
data as json.
Posted by Erik Selin <er...@jadedpixel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13635/
-----------------------------------------------------------
(Updated Sept. 9, 2013, 1:01 a.m.)
Review request for Sqoop.
Changes
-------
Tweaked patch and moved stuff to more appropriate places.
Bugs: https://issues.apache.org/jira/browse/SQOOP-1176
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1176
Repository: sqoop-trunk
Description
-------
Adding support for storing imported data as JSON.
Diffs (updated)
-----
ivy.xml d7486e0
src/java/org/apache/sqoop/SqoopOptions.java 01805f9
src/java/org/apache/sqoop/orm/ClassWriter.java 7fdf434
src/java/org/apache/sqoop/tool/BaseSqoopTool.java e02a93b
Diff: https://reviews.apache.org/r/13635/diff/
Testing
-------
Thanks,
Erik Selin