[GitHub] [incubator-daffodil] bsloane1650 opened a new pull request #229: Daffodil 2146 enum support fix1

[GitBox <gi...@apache.org>]

bsloane1650 opened a new pull request #229: Daffodil 2146 enum support fix1
URL: https://github.com/apache/incubator-daffodil/pull/229
 
 
   There were 2 minor bugs this fixes:
   
   1) Enumerations assumed that any repType has a corresponding typeDef. This is not true when the repType is a primitive type
   2) The type calculators set the current value to Maybe(...)
   
   In the processes of fixing this, I slightly refactored the code to catch the error that led to (2) as a type error at compile time. Our DPath interperator is still largly type-unsafe, which I would like to fix at somepoint.
   
   In looking into this, I also discovered that our Numbers.asAnyRef function is largly useless. I updated the code so that it is less misleading about what it is actually doing by turning it into a .asInstanceOf[AnyRef] call, which turns out to be exactly what was going on. I think we might want to remove the asAnyRef function entirely and box manually where nessasary, but did not feel like pulling at that string either.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services