[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

[GitBox <gi...@apache.org>]

clr-apache commented on pull request #120:
URL: https://github.com/apache/whimsy/pull/120#issuecomment-894702891


   The family first flag allows for the ICLA submitter to tell secretary that the names are culturally consistent. Secretary can then create the file name consistent with the current standard <given-names>-<family-name>. And in future, when secretary can directly create accounts, the givenName and sn can be consistent.
   
   Craig
   
   > On Aug 7, 2021, at 1:17 PM, sebbASF ***@***.***> wrote:
   > 
   > 
   > What is the use-case for this, now that the workbench does checks for name clashes?
   > 
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub <https://github.com/apache/whimsy/pull/120#issuecomment-894702563>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4M6RHBXZFUD3AD2OQFFWTT3WIGTANCNFSM5A5YANHQ>.
   > Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.
   > 
   
   Craig L Russell
   ***@***.***
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

[Craig Russell <ap...@gmail.com>]

I'd appreciate it if you all could take a look at the changes to secretary workbench.

If you're on the family-first branch I've been testing using config/setupmymac and the code works just as I like it to.

Future improvements can include delegating the LDAP sn and givenName to methods in lib/person.rb. 

But the family-first branch includes all the code necessary to properly handle the family first check box in the proposed ICLA.

Please review and comment. Unless there are other conflicts, this is ready to squash and merge.

Thanks,
Craig


> On Aug 7, 2021, at 1:20 PM, GitBox <gi...@apache.org> wrote:
> 
> 
> clr-apache commented on pull request #120:
> URL: https://github.com/apache/whimsy/pull/120#issuecomment-894702891
> 
> 
>   The family first flag allows for the ICLA submitter to tell secretary that the names are culturally consistent. Secretary can then create the file name consistent with the current standard <given-names>-<family-name>. And in future, when secretary can directly create accounts, the givenName and sn can be consistent.
> 
>   Craig
> 
>> On Aug 7, 2021, at 1:17 PM, sebbASF ***@***.***> wrote:
>> 
>> 
>> What is the use-case for this, now that the workbench does checks for name clashes?
>> 
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub <https://github.com/apache/whimsy/pull/120#issuecomment-894702563>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4M6RHBXZFUD3AD2OQFFWTT3WIGTANCNFSM5A5YANHQ>.
>> Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.
>> 
> 
>   Craig L Russell
>   ***@***.***
> 
> 
> 
> 
> -- 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
> 
> To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
> 
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
> 
> 

Craig L Russell
clr@apache.org