You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by xiaoqiu-vip <gi...@git.apache.org> on 2017/10/23 09:11:14 UTC
[GitHub] incubator-griffin pull request #144: Add Monitoring Module
GitHub user xiaoqiu-vip opened a pull request:
https://github.com/apache/incubator-griffin/pull/144
Add Monitoring Module
user : xiaoqiu.duan xiaoqiu2017wy@163.com
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiaoqiu-vip/incubator-griffin griffin-vip
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-griffin/pull/144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #144
----
----
---
[GitHub] incubator-griffin issue #144: Add Monitoring Module
Posted by bhlx3lyx7 <gi...@git.apache.org>.
Github user bhlx3lyx7 commented on the issue:
https://github.com/apache/incubator-griffin/pull/144
Hi @xiaoqiu-vip , I think the function is great, but in the code there're some hard codes, it's not appropriate for a common project, we recommend the specific literals as configuration, would you please modify it first?
Furthermore, it's better to write comments in English.
Thanks.
---
Re: [GitHub] incubator-griffin pull request #144: Add Monitoring
Module
Posted by William Guo <gu...@outlook.com>.
hi XiqoQiu,
Could you replace Chinese comments with english version in the pull 144?
Thanks,
William
________________________________
From: xiaoqiu-vip <gi...@git.apache.org>
Sent: Monday, October 23, 2017 5:11:14 PM
To: dev@griffin.incubator.apache.org
Subject: [GitHub] incubator-griffin pull request #144: Add Monitoring Module
GitHub user xiaoqiu-vip opened a pull request:
https://github.com/apache/incubator-griffin/pull/144
Add Monitoring Module
user : xiaoqiu.duan xiaoqiu2017wy@163.com
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiaoqiu-vip/incubator-griffin griffin-vip
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-griffin/pull/144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #144
----
----
---
[GitHub] incubator-griffin pull request #144: Add Monitoring Module
Posted by xiaoqiu-vip <gi...@git.apache.org>.
Github user xiaoqiu-vip closed the pull request at:
https://github.com/apache/incubator-griffin/pull/144
---