You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/10/29 18:53:16 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8457:
[fix] Improve csv upload functionality
codecov-io edited a comment on issue #8457: [fix] Improve csv upload functionality
URL: https://github.com/apache/incubator-superset/pull/8457#issuecomment-546665612
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8457?src=pr&el=h1) Report
> Merging [#8457](https://codecov.io/gh/apache/incubator-superset/pull/8457?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e704e29174cb603807c2f29fb3a63e592045010a?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8457?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8457 +/- ##
=========================================
+ Coverage 66.58% 66.6% +0.01%
=========================================
Files 448 449 +1
Lines 22492 22574 +82
Branches 2364 2367 +3
=========================================
+ Hits 14976 15035 +59
- Misses 7378 7401 +23
Partials 138 138
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8457?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/8457/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `27.85% <ø> (ø)` | :arrow_up: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/8457/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `91.11% <ø> (ø)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/8457/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.34% <100%> (+0.16%)` | :arrow_up: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/8457/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `92.15% <100%> (+8.64%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8457/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.47% <100%> (-0.26%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8457/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.15% <100%> (-0.07%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/8457/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `76.41% <0%> (-13.36%)` | :arrow_down: |
| [superset/views/database/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/8457/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvX19pbml0X18ucHk=) | `78.78% <0%> (-1.22%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8457/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.46% <0%> (-0.47%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/8457/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8457?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8457?src=pr&el=footer). Last update [e704e29...754794c](https://codecov.io/gh/apache/incubator-superset/pull/8457?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org