You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/29 07:39:09 UTC

[GitHub] [incubator-nuttx] CV-Bowen commented on a diff in pull request #7207: fs/poll: using callback mechanism to implement poll notification

CV-Bowen commented on code in PR #7207:
URL: https://github.com/apache/incubator-nuttx/pull/7207#discussion_r983171932


##########
drivers/net/telnet.c:
##########
@@ -1281,7 +1281,8 @@ static int telnet_io_main(int argc, FAR char** argv)
               (CONFIG_TELNET_RXBUFFER_SIZE -
                priv->td_pending - priv->td_offset) > 0)
             {
-              priv->td_fds.sem     = &g_iosem;
+              priv->td_fds.cbargs  = &g_iosem;

Review Comment:
   So i need add a net_dup() api to get the fd based on the psock and use this fd in telnet_io_main() ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org