[GitHub] [hadoop] ayushtkn commented on a change in pull request #3469: HDFS-16234.Improve DataNodeMetrics to initialize IBR more reasonable.

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #3469:
URL: https://github.com/apache/hadoop/pull/3469#discussion_r747693806



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/IncrementalBlockReportManager.java
##########
@@ -212,6 +212,8 @@ void sendIBRs(DatanodeProtocol namenode, DatanodeRegistration registration,
       namenode.blockReceivedAndDeleted(registration, bpid, reports);
       success = true;
     } finally {
+      /* set blocks to zero */
+      this.dnMetrics.resetBlocksInPendingIBR();

Review comment:
       Couldn't check in detail but shouldn't this be in success block? In case it isn't success, it puts the blocks back into the queue 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org