You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/19 15:49:26 UTC
[GitHub] [incubator-nuttx] anchao commented on a change in pull request
#308: support FIONBIO/MSG_DONTWAIT
anchao commented on a change in pull request #308: support FIONBIO/MSG_DONTWAIT
URL: https://github.com/apache/incubator-nuttx/pull/308#discussion_r381361056
##########
File path: libs/libc/stdio/lib_getdelim.c
##########
@@ -53,7 +53,7 @@
*/
#undef HAVE_GETLINE
-#if defined(CONFIG_EOL_IS_CR)
+#if defined(CONFIG_EOL_IS_CR) || defined(CONFIG_EOL_IS_EITHER_CRLF)
Review comment:
Yes, the processing logic just follows other similar code in apps cle, see:
apps/system/cle/cle.c:
`1108 /* Newline terminates editing. But what is a newline? */
1109
1110 #if defined(CONFIG_EOL_IS_CR) || defined(CONFIG_EOL_IS_EITHER_CRLF)
1111 case '\r': /* CR terminates line */
1112 `
i think in either case we can handler by CR in geline by default
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services