You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/07 19:27:33 UTC
[GitHub] [incubator-nuttx] patacongo opened a new issue #482: nxstyle:
header files that are not header files.
patacongo opened a new issue #482: nxstyle: header files that are not header files.
URL: https://github.com/apache/incubator-nuttx/issues/482
There is an issue with the graphics/nxglib/nxglib_fillrun.h header file (and probably others).
It is not really a header file. It is a "template" of a C file that is included with some definitions to make a complete C file. So it will NOT pass the tests for a header file.
See:
graphics/nxglib/lcd/nxglib_fillrectangle.c
graphics/nxglib/lcd/nxglib_filltrapezoid.c
It is not clear how this case should be handled. I believe we either have change the file name extension (but then it won't be checked at all) or change the extension to .c (which is misleading too).
Reference: PR #478
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #482: nxstyle:
header files that are not header files.
Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on issue #482: nxstyle: header files that are not header files.
URL: https://github.com/apache/incubator-nuttx/issues/482#issuecomment-597289659
Even if I state the obvious:
Name them .inc (or similar) and have nxstyle treat them as c file.
Should be a one liner...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #482:
nxstyle: header files that are not header files.
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #482: nxstyle: header files that are not header files.
URL: https://github.com/apache/incubator-nuttx/issues/482#issuecomment-597290899
> Even if I state the obvious:
> Name them .inc (or similar) and have nxstyle treat them as c file.
> Should be a one liner...
No, that was not obvious to me, but sounds like a good idea. The extension .inc is actuallly used by some toolchains. The ZiLOG tools, it is an assembly language header file. They use .src too which would be another good option. .inc is better beccause .src appears in most .gitignore files, I do not think that .inc does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #482: nxstyle:
header files that are not header files.
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #482: nxstyle: header files that are not header files.
URL: https://github.com/apache/incubator-nuttx/issues/482#issuecomment-597290899
> Even if I state the obvious:
> Name them .inc (or similar) and have nxstyle treat them as c file.
> Should be a one liner...
No, that was not obvious to me, but sounds like a good idea. The extension .inc is atuallly used by some toolchains (the ZiLOG tools, it is an assembly language header file).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #482:
nxstyle: header files that are not header files.
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #482: nxstyle: header files that are not header files.
URL: https://github.com/apache/incubator-nuttx/issues/482#issuecomment-597290899
> Even if I state the obvious:
> Name them .inc (or similar) and have nxstyle treat them as c file.
> Should be a one liner...
No, that was not obvious to me, but sounds like a good idea. The extension .inc is actuallly used by some toolchains. The ZiLOG tools, it is an assembly language header file. They use .src too which would be another good option. .inc is better beccause .src appears in most .gitignore files, I do nothing think that .inc does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services