[trafficserver] branch master updated: Removes a bogus check that tricks clang-analyzer to think it can be nullptr

[zw...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 9cab370  Removes a bogus check that tricks clang-analyzer to think it can be nullptr
9cab370 is described below

commit 9cab3702474f0646dcfd36d026a0bb635dc3bb1d
Author: Leif Hedstrom <zw...@apache.org>
AuthorDate: Thu May 10 15:23:30 2018 +0100

    Removes a bogus check that tricks clang-analyzer to think it can be nullptr
---
 proxy/InkAPI.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxy/InkAPI.cc b/proxy/InkAPI.cc
index d40522d..422ccdf 100644
--- a/proxy/InkAPI.cc
+++ b/proxy/InkAPI.cc
@@ -4919,7 +4919,7 @@ TSHttpTxnCachedRespModifiableGet(TSHttpTxn txnp, TSMBuffer *bufp, TSMLoc *obj)
   }
 
   c_resp = cached_obj_store->response_get();
-  if (c_resp == nullptr || !c_resp->valid()) {
+  if (!c_resp->valid()) {
     cached_obj_store->response_set(cached_obj->response_get());
   }
   c_resp                        = cached_obj_store->response_get();

-- 
To stop receiving notification emails like this one, please contact
zwoop@apache.org.