Re: svn commit: r1898525 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/upgrade.c libsvn_wc/wc.h svn/help-cmd.c svn/info-cmd.c svn/svn.c

[Daniel Shahaf <d....@daniel.shahaf.name>]

julianfoad@apache.org wrote on Wed, Mar 02, 2022 at 12:24:40 -0000:
> +++ subversion/trunk/subversion/include/svn_client.h Wed Mar  2 12:24:40 2022
> @@ -4471,23 +4463,8 @@ typedef struct svn_client_wc_format_t {
>   * @since New in 1.15.
>   */
>  const svn_version_t *
> -svn_client__wc_version_from_format(int wc_format,
> -                                   apr_pool_t *result_pool,
> -                                   apr_pool_t *scratch_pool);
> +svn_client_wc_version_from_format(int wc_format,
> +                                  apr_pool_t *result_pool);

Thanks for renaming this.

Recommend to remove RESULT_POOL too, since it is unused and the return
type is a pointer-to-const.

Cheers,

Daniel

Re: svn commit: r1898525 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/upgrade.c libsvn_wc/wc.h svn/help-cmd.c svn/info-cmd.c svn/svn.c

[Julian Foad <ju...@foad.me.uk>]

> Recommend to remove RESULT_POOL too, since it is unused and the return
> type is a pointer-to-const.

You're welcome to if you feel stronger than I do but it's off the bottom
of my priority list :-)

- Julian