You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/30 20:49:20 UTC
[GitHub] [maven-site] gnodet commented on a diff in pull request #346: [MNGSITE-501] Clarify profile jdk activation
gnodet commented on code in PR #346:
URL: https://github.com/apache/maven-site/pull/346#discussion_r1036426893
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -127,11 +129,12 @@ mvn groupId:artifactId:goal -P profile-1,profile-2,?profile-3
Profiles can be automatically triggered based on the detected state of
the build environment. These triggers are specified via an <<<\<activation\>>>>
section in the profile itself. Currently, this detection is limited to
- prefix-matching of the JDK version, the presence of a system property or
- the value of a system property. Here are some examples.
Review Comment:
`prefix` seems an important word to describe what happens here. Is that a willingful removal ?
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -127,11 +129,12 @@ mvn groupId:artifactId:goal -P profile-1,profile-2,?profile-3
Profiles can be automatically triggered based on the detected state of
the build environment. These triggers are specified via an <<<\<activation\>>>>
section in the profile itself. Currently, this detection is limited to
- prefix-matching of the JDK version, the presence of a system property or
- the value of a system property. Here are some examples.
+ matching of the JDK version, matching the operating system,
+ the presence of a system property or the value of a system property. Here are some examples.
Review Comment:
`the presence or value of a system property.`
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -127,11 +129,12 @@ mvn groupId:artifactId:goal -P profile-1,profile-2,?profile-3
Profiles can be automatically triggered based on the detected state of
the build environment. These triggers are specified via an <<<\<activation\>>>>
section in the profile itself. Currently, this detection is limited to
- prefix-matching of the JDK version, the presence of a system property or
- the value of a system property. Here are some examples.
+ matching of the JDK version, matching the operating system,
+ the presence of a system property or the value of a system property. Here are some examples.
The following configuration will trigger the profile when the JDK's
- version starts with "1.4" (eg. "1.4.0_08", "1.4.2_07", "1.4"):
+ version <starts with> "1.4" (eg. "1.4.0_08", "1.4.2_07", "1.4"), particularly it <won't be active>
Review Comment:
`particularly` -> `in particular`
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -127,11 +129,12 @@ mvn groupId:artifactId:goal -P profile-1,profile-2,?profile-3
Profiles can be automatically triggered based on the detected state of
the build environment. These triggers are specified via an <<<\<activation\>>>>
section in the profile itself. Currently, this detection is limited to
- prefix-matching of the JDK version, the presence of a system property or
- the value of a system property. Here are some examples.
+ matching of the JDK version, matching the operating system,
Review Comment:
`JDK version matching, operating system matching,`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org