You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/11 14:39:44 UTC
[GitHub] codecov-io commented on issue #4712: Added order_by() to SqlaTable
to ensure alphabetically ordered filter options values.
codecov-io commented on issue #4712: Added order_by() to SqlaTable to ensure alphabetically ordered filter options values.
URL: https://github.com/apache/incubator-superset/pull/4712#issuecomment-380476608
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4712?src=pr&el=h1) Report
> Merging [#4712](https://codecov.io/gh/apache/incubator-superset/pull/4712?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68dec245423a64808b6edb45ce2bedbbaf1a000d?src=pr&el=desc) will **increase** coverage by `0.41%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/4712?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4712 +/- ##
==========================================
+ Coverage 71.87% 72.29% +0.41%
==========================================
Files 204 208 +4
Lines 15323 15522 +199
Branches 1177 1202 +25
==========================================
+ Hits 11014 11222 +208
+ Misses 4306 4297 -9
Partials 3 3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4712?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.08% <ø> (-0.21%)` | :arrow_down: |
| [...ipts/explore/components/controls/FilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sLmpzeA==) | `97.29% <100%> (ø)` | :arrow_up: |
| [superset/assets/javascripts/modules/sandbox.js](https://codecov.io/gh/apache/incubator-superset/pull/4712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvc2FuZGJveC5qcw==) | `93.75% <0%> (-6.25%)` | :arrow_down: |
| [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4) | `63.15% <0%> (-1.55%)` | :arrow_down: |
| [...s/javascripts/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `73.52% <0%> (-1.48%)` | :arrow_down: |
| [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `38.02% <0%> (-1.24%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `78.41% <0%> (-1.21%)` | :arrow_down: |
| [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/4712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `97.7% <0%> (-1.05%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/4712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `46.83% <0%> (-0.91%)` | :arrow_down: |
| [...javascripts/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4712/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIuanN4) | `76.05% <0%> (-0.42%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/incubator-superset/pull/4712/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4712?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4712?src=pr&el=footer). Last update [68dec24...bdb540e](https://codecov.io/gh/apache/incubator-superset/pull/4712?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services