You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2017/12/05 16:57:00 UTC
[jira] [Commented] (SOLR-11617) Expose Alias Metadata CRUD in REST
API
[ https://issues.apache.org/jira/browse/SOLR-11617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278853#comment-16278853 ]
David Smiley commented on SOLR-11617:
-------------------------------------
Nice work Gus.
I can see your point about the name of MODIFYALIAS name being a bit dubious but I suppose it's a matter of perspective. If you view the alias & metadata as entirely separate then I think your recommendation for a different name is right. I think the user can think of this like collection configuration, which is basically metadata in a sense. I still like the name MODIFYALIAS. Maybe MODIFYALIAS should allow specifying what it points to as well as being usable for metadata? Granted I don't love having two ways to do one thing that are arbitrary but it at least enhances the sensibility of the MODIFYALIAS name/purpose.
Why the "or whitespace" qualification in the implementation and thus docs around the metadata value? Do other V2 API commands work this way? If so then keep it but otherwise I think whitespace shouldn't be special.
It seems this API can only handle setting one name-value at a time. I think it should be a bunch, perhaps using the sub-properties mechanism in the v2 doc, which _I think_ translates to say meta.mykey1=myvalue1&meta.mykey2=myvalue2 assuming we have a "meta" prefix.
minor: When returning the metadata, I think the outgoing map should be a LinkedHashMap so that the alias names are in the same order as earlier (whatever that may be).
> Expose Alias Metadata CRUD in REST API
> --------------------------------------
>
> Key: SOLR-11617
> URL: https://issues.apache.org/jira/browse/SOLR-11617
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Affects Versions: master (8.0)
> Reporter: Gus Heck
> Attachments: SOLR_11617.patch, SOLR_11617.patch
>
>
> SOLR-11487 is adding Java API for metadata on aliases, this task is to expose that functionality to end-users via a REST API.
> Some proposed commands, for initial discussion:
> - *SETALIASMETA* - upsert, or delete if blank/null/white-space provided.
> - *GETALIASMETA* - read existing alias metadata
> Given that the parent ticket to this task is going to rely on the alias metadata, and I suspect a user would potentially completely break their time partitioned data configuration by editing system metadata directly, we should either document these commands as "use at your own risk, great power/responsibility etc" or consider protecting some subset of metadata.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org