You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/08 09:30:05 UTC
[GitHub] [cordova-android] cdmahoney opened a new issue #1025: With cordova-android@9.0.0 defining versionNameSuffix in build-extras.gradle results in suffix being used as complete version name
cdmahoney opened a new issue #1025:
URL: https://github.com/apache/cordova-android/issues/1025
# Bug Report
## Problem
Defining versionNameSuffix in build-extras.gradle causes versionNameSuffix to be used as complete versionName with android@9.0.0. This worked correctly with android@8.0.0
### What is expected to happen?
versionNameSuffix should be appended to config.xml defined version, eg
version="1.0.0"
versionNameSuffix = ".debug"
Compiled application (debug build type) should have version name "1.0.0.debug".
### What does actually happen?
Actual version name is just versionNameSuffix , eg ".debug"
## Information
<!-- Include all relevant information that might help understand and reproduce the problem -->
To reproduce problem:
- Create new cordova project
- Add platform android@9.0.0
- Add build-extras.gradle shown below.
- Compile and test debug build type.
### Command or Code
<!-- What command or code is needed to reproduce the problem? -->
Sample build-extras.gradle
```
android {
buildTypes {
debug {
versionNameSuffix ".debug"
}
}
}
```
### Environment, Platform, Device
<!-- In what environment, on what platform or on which device are you experiencing the issue? -->
Compiling on Windows 10.
### Version information
<!--
What are relevant versions you are using?
For example:
Cordova: Cordova CLI, Cordova Platforms, Cordova Plugins
Other Frameworks: Ionic Framework and CLI version
Operating System, Android Studio, Xcode etc.
-->
Cordova CLI: 9.0.0 (cordova-lib@9.0.1)
Cordova android 9.0.0
## Checklist
<!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
- [x ] I searched for existing GitHub issues
- [x ] I updated all Cordova tooling to most recent version
- [ x] I included all the necessary information above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] cdmahoney commented on issue #1025: With cordova-android@9.0.0 defining versionNameSuffix in build-extras.gradle results in suffix being used as complete version name
Posted by GitBox <gi...@apache.org>.
cdmahoney commented on issue #1025:
URL: https://github.com/apache/cordova-android/issues/1025#issuecomment-655939140
OK thanks, no problem - for now I've just defined the suffix to be the complete version name in build-extras.gradle. Good enough for the debug version!
Colin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on issue #1025: With cordova-android@9.0.0 defining versionNameSuffix in build-extras.gradle results in suffix being used as complete version name
Posted by GitBox <gi...@apache.org>.
breautek commented on issue #1025:
URL: https://github.com/apache/cordova-android/issues/1025#issuecomment-655796788
Thank you for taking the time to fill out the issue form. I've Confirmed the issue.
On 8.1.0 I observed:
```
aapt dump badging app-debug.apk
package: name='io.cordova.hellocordova' versionCode='10000' versionName='1.0.0.debug' platformBuildVersionName='1.0.0.debug'
```
On 9.0.0 I observed:
```
aapt dump badging app-debug.apk
package: name='io.cordova.hellocordova' versionCode='10000' versionName='.debug' compileSdkVersion='29' compileSdkVersionCodename='10'
```
Not sure on the cause, I don't have a workaround at this time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on issue #1025: With cordova-android@9.0.0 defining versionNameSuffix in build-extras.gradle results in suffix being used as complete version name
Posted by GitBox <gi...@apache.org>.
breautek commented on issue #1025:
URL: https://github.com/apache/cordova-android/issues/1025#issuecomment-671601815
This appears to be a regression bug in the `Android Gradle Plugin` version 4.0.0.
https://issuetracker.google.com/issues/158454676
It's assigned and open, and claims to be effort to get this fixed in `4.0.1`. I'll leave this ticket open as a reminder, so that we can upgrade the framework to the patched version when it becomes available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org