You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/06 07:14:02 UTC
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6267
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
[DOCS] Wide-ranging cleanup of CDH and Cloudera references
Genericize 3-part version numbers in "known issues".
Genericize CDH version numbers in 'ports' topic.
Genericize 'Cloudera' and hostnames in 'Tables' topic.
Genericize the version numbers in 'added in' blurbs.
Remove lots of CDH / Impala notices from release notes.
Remove obsolete conref'able elements that weren't
actually being called from anywhere, that contained
CDH version number wording.
Reword 'Cloudera recommends'.
Remove more hidden or commented material with
Cloudera-specific wording.
Remove obsolete CDH references from 'incompatible changes'.
Change 'cloudera' HDFS username for LOAD DATA examples.
Remove material related to big lists of CDH fixed JIRAs.
Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_create_function.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_describe.xml
M docs/topics/impala_drop_function.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_load_data.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_ports.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_runtime_filtering.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_show.xml
M docs/topics/impala_tables.xml
M docs/topics/impala_timestamp.xml
M docs/topics/impala_tutorial.xml
M docs/topics/impala_v_cpu_cores.xml
M docs/topics/impala_varchar.xml
26 files changed, 172 insertions(+), 752 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/6267/1
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#3).
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
[DOCS] Wide-ranging cleanup of CDH and Cloudera references
Genericize 3-part version numbers in "known issues".
Genericize CDH version numbers in 'ports' topic.
Genericize 'Cloudera' and hostnames in 'Tables' topic.
Genericize the version numbers in 'added in' blurbs.
Remove lots of CDH / Impala notices from release notes.
Remove obsolete conref'able elements that weren't
actually being called from anywhere, that contained
CDH version number wording.
Reword 'Cloudera recommends'.
Remove more hidden or commented material with
Cloudera-specific wording.
Remove obsolete CDH references from 'incompatible changes'.
Change 'cloudera' HDFS username for LOAD DATA examples.
Remove material related to big lists of CDH fixed JIRAs.
Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_create_function.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_describe.xml
M docs/topics/impala_drop_function.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_load_data.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_ports.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_runtime_filtering.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_show.xml
M docs/topics/impala_tables.xml
M docs/topics/impala_timestamp.xml
M docs/topics/impala_tutorial.xml
M docs/topics/impala_v_cpu_cores.xml
M docs/topics/impala_varchar.xml
26 files changed, 337 insertions(+), 1,154 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/6267/3
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
Patch Set 4: Code-Review+2
Nothing controversial in this one, just basic cleanup.
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
Patch Set 1:
(19 comments)
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
PS1, Line 3382: TSB-168
Remove.
PS1, Line 3407: udience="Cloudera
Might want to take out the entire section here.
PS1, Line 3408: OPSAPS-26483
Remove.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_compute_stats.xml
File docs/topics/impala_compute_stats.xml:
PS1, Line 508: CDH-19187
CDH jira.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_create_function.xml
File docs/topics/impala_create_function.xml:
PS1, Line 54: CDH-39148
It looks like none of the references to CDH jira numbers were removed from this topic.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_describe.xml
File docs/topics/impala_describe.xml:
PS1, Line 691: CDH-19187
CDH jira.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_drop_function.xml
File docs/topics/impala_drop_function.xml:
PS1, Line 54: CDH-39148
CDH jira - several scattered references across this topic.
PS1, Line 112: cdh570.j
make jar name generic.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:
PS1, Line 251: CDH 5.7.4
Will you be replacing all the CDH version numbers in the titles?
PS1, Line 282: CDH 5.7.0 / Impala 2.5.0
Replace with keyref.
PS1, Line 283: https://issues.cloudera.org
do we need to change these links or can we rely on the redirects once we migrate to apache jira?
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:
PS1, Line 144: CDH-43734
CDH jira - other occurrences in this topic as well.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
PS1, Line 589: TSB-168
TSB jira.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_load_data.xml
File docs/topics/impala_load_data.xml:
PS1, Line 245: CDH-19187
CDH jira.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:
PS1, Line 582: CDH-33310
CDH jiras and references to CDH x.x / Impala x.x in this topic.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_prereqs.xml
File docs/topics/impala_prereqs.xml:
Line 55: <concept id="product_compatibility_matrix">
We could either delete this whole section, or copy the Impala table from the PCM here. I do think this work is being done by Laurel in a separate gerrit though.
PS1, Line 94: CDH 5 platforms
We need to unhide the list of supported OSs since we can't point them to a CDH doc anymore.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_runtime_filtering.xml
File docs/topics/impala_runtime_filtering.xml:
PS1, Line 62: CDH-41184
CDH jira.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_s3.xml
File docs/topics/impala_s3.xml:
PS1, Line 219: CDH-39913
CDH jira
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
Patch Set 1:
(6 comments)
Most of this looks great, but I was a little confused about your intended scoping and about one of the included topics not showing up in the build. However, it did build html & pdf without throwing any errors.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala.xml
File docs/topics/impala.xml:
This file didn't get picked up in the build. The build didn't contain any "impala.html." Is that expected behavior?
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:
Shouldn't many of these CDH references have been removed as part of "Remove material related to big lists of CDH fixed JIRAs."? Maybe I don't understand the scoping?
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:
PS1, Line 1318: impala-lzo-cdh4
Is it impossible to remove this reference?
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
PS1, Line 356: CDH
Don't "CDH" references like this fall into the cleanup categories of this patch?
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_misc_functions.xml
File docs/topics/impala_misc_functions.xml:
PS1, Line 75: eyword keyref="impala225"
Your replacement mechanism works great!
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:
PS1, Line 1343: CDH
Still 19 CDH references showing up in the built docs.
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
[DOCS] Wide-ranging cleanup of CDH and Cloudera references
Genericize 3-part version numbers in "known issues".
Genericize CDH version numbers in 'ports' topic.
Genericize 'Cloudera' and hostnames in 'Tables' topic.
Genericize the version numbers in 'added in' blurbs.
Remove lots of CDH / Impala notices from release notes.
Remove obsolete conref'able elements that weren't
actually being called from anywhere, that contained
CDH version number wording.
Reword 'Cloudera recommends'.
Remove more hidden or commented material with
Cloudera-specific wording.
Remove obsolete CDH references from 'incompatible changes'.
Change 'cloudera' HDFS username for LOAD DATA examples.
Remove material related to big lists of CDH fixed JIRAs.
Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_create_function.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_describe.xml
M docs/topics/impala_drop_function.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_load_data.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_ports.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_runtime_filtering.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_show.xml
M docs/topics/impala_tables.xml
M docs/topics/impala_timestamp.xml
M docs/topics/impala_tutorial.xml
M docs/topics/impala_v_cpu_cores.xml
M docs/topics/impala_varchar.xml
26 files changed, 336 insertions(+), 1,127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/6267/2
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
Patch Set 3:
Patch set 3 is to fix some merge conflicts. E.g. where Laurel had rewritten a reference to Cloudera Manager near where I changed a reference to a CDH version number, or in some shared content where Laurel rewrote CM language but I was able to get rid of it entirely b/c it wasn't used anywhere.
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
Patch Set 4: Code-Review+1
Looks good, builds clean.
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#4).
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
[DOCS] Wide-ranging cleanup of CDH and Cloudera references
Genericize 3-part version numbers in "known issues".
Genericize CDH version numbers in 'ports' topic.
Genericize 'Cloudera' and hostnames in 'Tables' topic.
Genericize the version numbers in 'added in' blurbs.
Remove lots of CDH / Impala notices from release notes.
Remove obsolete conref'able elements that weren't
actually being called from anywhere, that contained
CDH version number wording.
Reword 'Cloudera recommends'.
Remove more hidden or commented material with
Cloudera-specific wording.
Remove obsolete CDH references from 'incompatible changes'.
Change 'cloudera' HDFS username for LOAD DATA examples.
Remove material related to big lists of CDH fixed JIRAs.
Genericize some CDH-related language.
Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_create_function.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_describe.xml
M docs/topics/impala_drop_function.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_load_data.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_ports.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_runtime_filtering.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_show.xml
M docs/topics/impala_tables.xml
M docs/topics/impala_timestamp.xml
M docs/topics/impala_tutorial.xml
M docs/topics/impala_v_cpu_cores.xml
M docs/topics/impala_varchar.xml
26 files changed, 344 insertions(+), 1,305 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/6267/4
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
Patch Set 1:
(25 comments)
Addressed all comments.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
PS1, Line 3382: TSB-168
> Remove.
Done
PS1, Line 3407: udience="Cloudera
> Might want to take out the entire section here.
Because it's a CM thing I'm leaving it alone for the moment to avoid merge conflicts with Laurel's stuff.
PS1, Line 3408: OPSAPS-26483
> Remove.
Same as above.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala.xml
File docs/topics/impala.xml:
> This file didn't get picked up in the build. The build didn't contain any "
It is a high-level topic that's only displayed in the context of the CDH library, with everything else grouped underneath it. These same conrefs are used elsewhere too, so there's not any content missing in the upstream docs. I'm not going to worry about it being superfluous for the moment, just going to make sure the Cloudera-specific references are gone from our grep report.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_compute_stats.xml
File docs/topics/impala_compute_stats.xml:
PS1, Line 508: CDH-19187
> CDH jira.
Done
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_create_function.xml
File docs/topics/impala_create_function.xml:
PS1, Line 54: CDH-39148
> It looks like none of the references to CDH jira numbers were removed from
Done. I was focusing on the CDH version numbers, which are more of a factor because they're visible in the output, but now that you got me started I'll do these invisible references to JIRAs also.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_describe.xml
File docs/topics/impala_describe.xml:
PS1, Line 691: CDH-19187
> CDH jira.
Done
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_drop_function.xml
File docs/topics/impala_drop_function.xml:
PS1, Line 54: CDH-39148
> CDH jira - several scattered references across this topic.
Done
PS1, Line 112: cdh570.j
> make jar name generic.
Done
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:
Line 88: <title>Issues Fixed in Impala for CDH 5.8.3</title>
> Why have this section if it is going to be empty?
We can reconstruct the history and make links to JIRA reports as a subsequent step. Probably after JIRA migration is finished so we can use the final final URLs. For now I mainly care about reducing the number of Cloudera-specific references.
PS1, Line 251: CDH 5.7.4
> Will you be replacing all the CDH version numbers in the titles?
Yes. Requires adding some new items in impala_keydefs.ditamap.
PS1, Line 282: CDH 5.7.0 / Impala 2.5.0
> Replace with keyref.
Done
PS1, Line 283: https://issues.cloudera.org
> do we need to change these links or can we rely on the redirects once we mi
We'll rely on redirects for the moment, and replace once we have the new URLs in place to test.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:
PS1, Line 144: CDH-43734
> CDH jira - other occurrences in this topic as well.
Done
PS1, Line 1318: impala-lzo-cdh4
> Is it impossible to remove this reference?
I'll change the wording to avoid mentioning the precise package name.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
PS1, Line 356: CDH
> Don't "CDH" references like this fall into the cleanup categories of this p
Done
PS1, Line 589: TSB-168
> TSB jira.
Done
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_load_data.xml
File docs/topics/impala_load_data.xml:
PS1, Line 245: CDH-19187
> CDH jira.
Done
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_misc_functions.xml
File docs/topics/impala_misc_functions.xml:
PS1, Line 75: eyword keyref="impala225"
> Your replacement mechanism works great!
Done
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:
PS1, Line 582: CDH-33310
> CDH jiras and references to CDH x.x / Impala x.x in this topic.
I have a sinking feeling that I'm doing some of these changes for the second time and it'll result in a merge conflict. But let's see.
Also I'm removing some hidden or otherwise stale or inappropriate info that doesn't make sense to genericize (e.g. DSSD certification).
PS1, Line 1343: CDH
> Still 19 CDH references showing up in the built docs.
Done
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_prereqs.xml
File docs/topics/impala_prereqs.xml:
Line 55: <concept id="product_compatibility_matrix">
> We could either delete this whole section, or copy the Impala table from th
Deleting for the moment.
PS1, Line 94: CDH 5 platforms
> We need to unhide the list of supported OSs since we can't point them to a
I'm going to fix links to CDH docs in a subsequent pass and will address this issue then.
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_runtime_filtering.xml
File docs/topics/impala_runtime_filtering.xml:
PS1, Line 62: CDH-41184
> CDH jira.
Done
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_s3.xml
File docs/topics/impala_s3.xml:
PS1, Line 219: CDH-39913
> CDH jira
Done
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/65/
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6267/1/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:
Line 88: <title>Issues Fixed in Impala for CDH 5.8.3</title>
Why have this section if it is going to be empty?
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6267/2/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:
PS2, Line 1871: CDH
CDH ref -- comes up in a ctrl+F on the rendered page -- there are a few more on this page that are not parts of links to the CDH docs.
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
[DOCS] Wide-ranging cleanup of CDH and Cloudera references
Genericize 3-part version numbers in "known issues".
Genericize CDH version numbers in 'ports' topic.
Genericize 'Cloudera' and hostnames in 'Tables' topic.
Genericize the version numbers in 'added in' blurbs.
Remove lots of CDH / Impala notices from release notes.
Remove obsolete conref'able elements that weren't
actually being called from anywhere, that contained
CDH version number wording.
Reword 'Cloudera recommends'.
Remove more hidden or commented material with
Cloudera-specific wording.
Remove obsolete CDH references from 'incompatible changes'.
Change 'cloudera' HDFS username for LOAD DATA examples.
Remove material related to big lists of CDH fixed JIRAs.
Genericize some CDH-related language.
Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Reviewed-on: http://gerrit.cloudera.org:8080/6267
Reviewed-by: Ambreen Kazi <am...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_create_function.xml
M docs/topics/impala_decimal.xml
M docs/topics/impala_describe.xml
M docs/topics/impala_drop_function.xml
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_known_issues.xml
M docs/topics/impala_load_data.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_ports.xml
M docs/topics/impala_prereqs.xml
M docs/topics/impala_revoke.xml
M docs/topics/impala_runtime_filtering.xml
M docs/topics/impala_s3.xml
M docs/topics/impala_show.xml
M docs/topics/impala_tables.xml
M docs/topics/impala_timestamp.xml
M docs/topics/impala_tutorial.xml
M docs/topics/impala_v_cpu_cores.xml
M docs/topics/impala_varchar.xml
26 files changed, 344 insertions(+), 1,305 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Ambreen Kazi: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] [DOCS] Wide-ranging cleanup of CDH and Cloudera references
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Wide-ranging cleanup of CDH and Cloudera references
......................................................................
Patch Set 4:
(1 comment)
Addressed Ambreen's comment, which resulted in a cascade affecting a bunch more lines, including some removal of commented stuff.
http://gerrit.cloudera.org:8080/#/c/6267/2/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:
PS2, Line 1871:
> CDH ref -- comes up in a ctrl+F on the rendered page -- there are a few mo
Done. For this review, I was going to limit myself to places where CDH version numbers were referenced, but since there are just these few stray CDH references I'll take those out too. E.g. all the references in comments to CDH- JIRAs, which results in removing a few whole comment blocks.
I left one fixed issue that references 'CDH4.5' in the JIRA title because that's authentic historical info.
--
To view, visit http://gerrit.cloudera.org:8080/6267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5db6c20f4d010972ade4945a3ea59b32ef95de
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes