You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yew1eb <gi...@git.apache.org> on 2018/03/20 16:13:13 UTC
[GitHub] flink pull request #5731: [FLINK-9033][config] Replace usages of deprecated ...
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5731
[FLINK-9033][config] Replace usages of deprecated TASK_MANAGER_NUM_TASK_SLOTS
## What is the purpose of the change
The deprecated ConfigConstants#TASK_MANAGER_NUM_TASK_SLOTS is still used a lot.
We should replace these usages with TaskManagerOptions#NUM_TASK_SLOTS.
## Verifying this change
- `mvn clean verify`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink FLINK-9033
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5731.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5731
----
----
---
[GitHub] flink pull request #5731: [FLINK-9033][config] Replace usages of deprecated ...
Posted by yew1eb <gi...@git.apache.org>.
Github user yew1eb commented on a diff in the pull request:
https://github.com/apache/flink/pull/5731#discussion_r177616520
--- Diff: flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITCase.scala ---
@@ -23,7 +23,7 @@ import java.io._
import akka.actor.ActorRef
import akka.pattern.Patterns
import org.apache.flink.runtime.minicluster.StandaloneMiniCluster
-import org.apache.flink.configuration.{ConfigConstants, Configuration, CoreOptions, GlobalConfiguration}
+import org.apache.flink.configuration._
--- End diff --
make sense.
---
[GitHub] flink issue #5731: [FLINK-9033][config] Replace usages of deprecated TASK_MA...
Posted by yew1eb <gi...@git.apache.org>.
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5731
@greghogan I have updated this PR, Please look it again.:mask:
---
[GitHub] flink issue #5731: [FLINK-9033][config] Replace usages of deprecated TASK_MA...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5731
Test failures, and needs rebasing.
---
[GitHub] flink pull request #5731: [FLINK-9033][config] Replace usages of deprecated ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5731
---
[GitHub] flink pull request #5731: [FLINK-9033][config] Replace usages of deprecated ...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5731#discussion_r177536243
--- Diff: flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITCase.scala ---
@@ -23,7 +23,7 @@ import java.io._
import akka.actor.ActorRef
import akka.pattern.Patterns
import org.apache.flink.runtime.minicluster.StandaloneMiniCluster
-import org.apache.flink.configuration.{ConfigConstants, Configuration, CoreOptions, GlobalConfiguration}
+import org.apache.flink.configuration._
--- End diff --
I think in this case we can avoid the wildcard import.
---
[GitHub] flink issue #5731: [FLINK-9033][config] Replace usages of deprecated TASK_MA...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5731
merging.
---
[GitHub] flink issue #5731: [FLINK-9033][config] Replace usages of deprecated TASK_MA...
Posted by yew1eb <gi...@git.apache.org>.
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5731
@greghogan thanks for your review. I have updated this PR.
---