You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2024/01/11 00:04:33 UTC
[PR] [SPARK-46666][PYTHON][TESTS] Make lxml as an optional testing dependency in test_session [spark]
HyukjinKwon opened a new pull request, #44676:
URL: https://github.com/apache/spark/pull/44676
### What changes were proposed in this pull request?
This PR proposes to make `lxml` as an optional testing dependency in the `test_session` test
### Why are the changes needed?
To make the tests pass without optional testing dependencies, see https://github.com/apache/spark/actions/runs/7476792796/job/20348097114
```
Starting test(python3.12): pyspark.sql.tests.test_session (temp output: /__w/spark/spark/python/target/5136bb6a-ba9d-4533-925c-adf338021fa0/python3.12__pyspark.sql.tests.test_session__yahhd4j3.log)
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/__w/spark/spark/python/pyspark/sql/tests/test_session.py", line 22, in <module>
from lxml import etree
ModuleNotFoundError: No module named 'lxml'
```
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
Manaully.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46666][PYTHON][TESTS] Make lxml as an optional testing dependency in test_session [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44676:
URL: https://github.com/apache/spark/pull/44676#issuecomment-1885958435
build: https://github.com/HyukjinKwon/spark/actions/runs/7482270214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46666][PYTHON][TESTS] Make lxml as an optional testing dependency in test_session [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44676:
URL: https://github.com/apache/spark/pull/44676#issuecomment-1886266302
I am going to merge this because technically this is fixing the scheduled regular builds, and the new build starts soon.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46666][PYTHON][TESTS] Make lxml as an optional testing dependency in test_session [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44676: [SPARK-46666][PYTHON][TESTS] Make lxml as an optional testing dependency in test_session
URL: https://github.com/apache/spark/pull/44676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org