You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/02/16 02:28:36 UTC

[GitHub] [cordova-android] dpogue commented on issue #894: (android) Additional WebView preferences: 'UseWideViewport', 'SaveFormData', 'SavePassword'

dpogue commented on issue #894: (android) Additional WebView preferences: 'UseWideViewport', 'SaveFormData', 'SavePassword'
URL: https://github.com/apache/cordova-android/pull/894#issuecomment-586661693
 
 
   `setSaveFormData` and `setSavePassword` are deprecated methods, so the best thing to do is probably to remove them from the code entirely. The behaviour of saving (or not) can be managed by the app author on a more specific level using HTML attributes.
   
   I think we always want `setUseWideViewPort(true)` so that it obeys the viewport as specified by the app author.
   
   As much as possible, we should allow things to be controlled by the app author via their HTML as opposed to via config preferences.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org