You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/05 01:21:50 UTC
[GitHub] [orc] williamhyun opened a new pull request #816: ORC-910: Enforce maven-dependency-plugin
williamhyun opened a new pull request #816:
URL: https://github.com/apache/orc/pull/816
### What changes were proposed in this pull request?
This PR aims to enforce maven-dependency-plugin.
### Why are the changes needed?
This will prevent unintended dependency changes.
### How was this patch tested?
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #816:
URL: https://github.com/apache/orc/pull/816#issuecomment-893097773
I verified this by checking the GitHub Action log.
```
[INFO] --- maven-dependency-plugin:3.1.2:analyze-only (default) @ orc-shims ---
[INFO] No dependency problems found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #816:
URL: https://github.com/apache/orc/pull/816#discussion_r683067234
##########
File path: java/tools/pom.xml
##########
@@ -62,7 +66,7 @@
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs</artifactId>
+ <artifactId>hadoop-hdfs-client</artifactId>
Review comment:
Thank you for catching this, @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on a change in pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
williamhyun commented on a change in pull request #816:
URL: https://github.com/apache/orc/pull/816#discussion_r683061847
##########
File path: java/bench/pom.xml
##########
@@ -468,6 +468,15 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <configuration>
+ <ignoredDependencies>
+ <ignoredDependency>*:*</ignoredDependency>
+ </ignoredDependencies>
+ </configuration>
+ </plugin>
Review comment:
`benchmark` module is not published to the Maven Central.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on a change in pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
williamhyun commented on a change in pull request #816:
URL: https://github.com/apache/orc/pull/816#discussion_r683063885
##########
File path: java/tools/pom.xml
##########
@@ -62,7 +66,7 @@
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs</artifactId>
+ <artifactId>hadoop-hdfs-client</artifactId>
Review comment:
After ORC-603 (https://github.com/apache/orc/pull/607), we use `hadoop-hdfs-client`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #816:
URL: https://github.com/apache/orc/pull/816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #816:
URL: https://github.com/apache/orc/pull/816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #816:
URL: https://github.com/apache/orc/pull/816#issuecomment-893093614
cc: @dongjoon-hyun @pgaref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #816:
URL: https://github.com/apache/orc/pull/816#issuecomment-893093614
cc: @dongjoon-hyun @pgaref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #816:
URL: https://github.com/apache/orc/pull/816#issuecomment-893097773
I verified this by checking the GitHub Action log.
```
[INFO] --- maven-dependency-plugin:3.1.2:analyze-only (default) @ orc-shims ---
[INFO] No dependency problems found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #816:
URL: https://github.com/apache/orc/pull/816#discussion_r683067234
##########
File path: java/tools/pom.xml
##########
@@ -62,7 +66,7 @@
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs</artifactId>
+ <artifactId>hadoop-hdfs-client</artifactId>
Review comment:
Thank you for catching this, @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on a change in pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
williamhyun commented on a change in pull request #816:
URL: https://github.com/apache/orc/pull/816#discussion_r683061847
##########
File path: java/bench/pom.xml
##########
@@ -468,6 +468,15 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <configuration>
+ <ignoredDependencies>
+ <ignoredDependency>*:*</ignoredDependency>
+ </ignoredDependencies>
+ </configuration>
+ </plugin>
Review comment:
`benchmark` module is not published to the Maven Central.
##########
File path: java/pom.xml
##########
@@ -306,6 +306,22 @@
<failOnViolation>true</failOnViolation>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.1.2</version>
Review comment:
3.2.x has a bug. So, we should use the latest 3.1.x which is 3.1.2.
##########
File path: java/pom.xml
##########
@@ -306,6 +306,22 @@
<failOnViolation>true</failOnViolation>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.1.2</version>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>analyze-only</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <failOnWarning>true</failOnWarning>
Review comment:
This will enforce this plugin in `analyze` profile.
##########
File path: java/tools/pom.xml
##########
@@ -62,7 +66,7 @@
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs</artifactId>
+ <artifactId>hadoop-hdfs-client</artifactId>
Review comment:
After ORC-603 (https://github.com/apache/orc/pull/607), we use `hadoop-hdfs-client`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on a change in pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
williamhyun commented on a change in pull request #816:
URL: https://github.com/apache/orc/pull/816#discussion_r683062216
##########
File path: java/pom.xml
##########
@@ -306,6 +306,22 @@
<failOnViolation>true</failOnViolation>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.1.2</version>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>analyze-only</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <failOnWarning>true</failOnWarning>
Review comment:
This will enforce this plugin in `analyze` profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on a change in pull request #816: ORC-910: Enforce maven-dependency-plugin
Posted by GitBox <gi...@apache.org>.
williamhyun commented on a change in pull request #816:
URL: https://github.com/apache/orc/pull/816#discussion_r683062069
##########
File path: java/pom.xml
##########
@@ -306,6 +306,22 @@
<failOnViolation>true</failOnViolation>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.1.2</version>
Review comment:
3.2.x has a bug. So, we should use the latest 3.1.x which is 3.1.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org