You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Konrad Windszus <kw...@apache.org> on 2023/05/15 11:02:45 UTC

[VOTE] Release Apache Sling OSGi Installer Configuration Factory 1.4.4 and OSGi Installer Console 1.1.2

Hi, 

We solved 1 issues in these releases: https://issues.apache.org/jira/browse/SLING-11864

Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2747/ 
You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD 
Usage: sh check_staged_release.sh 2747 /tmp/sling-staging 

Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because … 

This majority vote is open for at least 72 hours.

Thanks in advance for taking the time to check and vote,
Konrad

RE: [VOTE] Release Apache Sling OSGi Installer Configuration Factory 1.4.4 and OSGi Installer Console 1.1.2

Posted by Stefan Seifert <St...@diva-e.com.INVALID>.
+1

stefan

[RESULT] [VOTE] Release Apache Sling OSGi Installer Configuration Factory 1.4.4 and OSGi Installer Console 1.1.2

Posted by Konrad Windszus <kw...@apache.org>.
Hi, The vote has passed with the following result : 

+1 (binding): Stefan, Robert and myself
+1 (non binding): none

I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository.

Thanks for voting,
Konrad

> On 15. May 2023, at 13:02, Konrad Windszus <kw...@apache.org> wrote:
> 
> Hi, 
> 
> We solved 1 issues in these releases: https://issues.apache.org/jira/browse/SLING-11864
> 
> Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2747/ 
> You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD 
> Usage: sh check_staged_release.sh 2747 /tmp/sling-staging 
> 
> Please vote to approve this release:
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because … 
> 
> This majority vote is open for at least 72 hours.
> 
> Thanks in advance for taking the time to check and vote,
> Konrad

Re: [VOTE] Release Apache Sling OSGi Installer Configuration Factory 1.4.4 and OSGi Installer Console 1.1.2

Posted by Konrad Windszus <kw...@apache.org>.
+1

Konrad

> On 15. May 2023, at 13:02, Konrad Windszus <kw...@apache.org> wrote:
> 
> Hi, 
> 
> We solved 1 issues in these releases: https://issues.apache.org/jira/browse/SLING-11864
> 
> Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2747/ 
> You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD 
> Usage: sh check_staged_release.sh 2747 /tmp/sling-staging 
> 
> Please vote to approve this release:
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because … 
> 
> This majority vote is open for at least 72 hours.
> 
> Thanks in advance for taking the time to check and vote,
> Konrad

Re: Test failures with Java 17 - Apache Sling OSGi Installer Configuration Factory 1.4.4 and OSGi Installer Console 1.1.2

Posted by Konrad Windszus <kw...@apache.org>.
FTR: I created https://issues.apache.org/jira/browse/SLING-11880 to track that and fixed that in the upcoming version.
The fix only affects the test class path and should therefore have no impact on OSGi distributions using already org.osgi.util.converter 1.0.8 or newer.
Thanks for reporting,
Konrad

> On 15. May 2023, at 14:37, Robert Munteanu <ro...@apache.org> wrote:
> 
> On Mon, 2023-05-15 at 13:02 +0200, Konrad Windszus wrote:
>> Usage: sh check_staged_release.sh 2747 /tmp/sling-staging 
> 
> For the record, the tests fail for me on Java 17
> 
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.339 s <<< FAILURE! - in
> org.apache.sling.installer.factories.configuration.impl.MetatypeHandler
> Test
> [ERROR]
> org.apache.sling.installer.factories.configuration.impl.MetatypeHandler
> Test.testUpdateConfiguration  Time elapsed: 0.337 s  <<< FAILURE!
> java.lang.AssertionError: expected:<3> but was:<4>
> 	at org.junit.Assert.fail(Assert.java:89)
> 	at org.junit.Assert.failNotEquals(Assert.java:835)
> 	at org.junit.Assert.assertEquals(Assert.java:647)
> 	at org.junit.Assert.assertEquals(Assert.java:633)
> 	at
> org.apache.sling.installer.factories.configuration.impl.MetatypeHandler
> Test.testUpdateConfiguration(MetatypeHandlerTest.java:109)
> 
> They pass with Java 11 and I doubt it's a regression so I voted +1 on
> the release (see my previous email).
> 
> Thanks,
> Robert

Test failures with Java 17 - Apache Sling OSGi Installer Configuration Factory 1.4.4 and OSGi Installer Console 1.1.2

Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2023-05-15 at 13:02 +0200, Konrad Windszus wrote:
> Usage: sh check_staged_release.sh 2747 /tmp/sling-staging 

For the record, the tests fail for me on Java 17

[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.339 s <<< FAILURE! - in
org.apache.sling.installer.factories.configuration.impl.MetatypeHandler
Test
[ERROR]
org.apache.sling.installer.factories.configuration.impl.MetatypeHandler
Test.testUpdateConfiguration  Time elapsed: 0.337 s  <<< FAILURE!
java.lang.AssertionError: expected:<3> but was:<4>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
	at
org.apache.sling.installer.factories.configuration.impl.MetatypeHandler
Test.testUpdateConfiguration(MetatypeHandlerTest.java:109)

They pass with Java 11 and I doubt it's a regression so I voted +1 on
the release (see my previous email).

Thanks,
Robert

Re: [VOTE] Release Apache Sling OSGi Installer Configuration Factory 1.4.4 and OSGi Installer Console 1.1.2

Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2023-05-15 at 13:02 +0200, Konrad Windszus wrote:
> Please vote to approve this release:

+1
Robert