You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/30 17:34:03 UTC

[GitHub] [druid] gianm commented on a change in pull request #7590: Add single-machine deployment example cfgs and scripts

gianm commented on a change in pull request #7590:
URL: https://github.com/apache/druid/pull/7590#discussion_r418175612



##########
File path: examples/bin/run-druid
##########
@@ -34,7 +34,7 @@ else
   CONFDIR="$2"
 fi
 
-CONFDIR="$(cd "$CONFDIR" && pwd)/druid"
+CONFDIR="$(cd "$CONFDIR" && pwd)"

Review comment:
       Hi @knoguchi,
   
   It was changed to comport with the new directory structure in this patch, where we ship with multiple potential configurations for various sizes of servers. (It no longer makes sense to add `/druid` to the conf dir, since we provide the full path to a Druid-specific conf dir in the supervise configs.)
   
   I think we should have noted this in the release notes, though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org