[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10124: IGNITE-17277 Added a user info to the sql queries view

[GitBox <gi...@apache.org>]

NSAmelchev commented on code in PR #10124:
URL: https://github.com/apache/ignite/pull/10124#discussion_r911848993


##########
modules/indexing/src/test/java/org/apache/ignite/internal/systemview/SystemViewSecurityTest.java:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.systemview;
+
+import java.util.Map;
+import org.apache.ignite.cache.query.SqlFieldsQuery;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.processors.security.AbstractSecurityTest;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.spi.systemview.view.SqlQueryView;
+import org.apache.ignite.spi.systemview.view.SystemView;
+import org.junit.Test;
+
+import static org.apache.ignite.internal.processors.query.RunningQueryManager.SQL_QRY_VIEW;
+
+/**
+ * System view security test.
+ */
+public class SystemViewSecurityTest extends AbstractSecurityTest {
+    /** @throws Exception If failed. */
+    @Test
+    public void testSqlQueryView() throws Exception {
+        IgniteEx srv = startGridAllowAll("srv");
+        IgniteEx client = startClientAllowAll("client");
+
+        SqlFieldsQuery srvSql = new SqlFieldsQuery("SELECT * FROM (VALUES (1),(2))");
+        SqlFieldsQuery clientSql = new SqlFieldsQuery("SELECT * FROM (VALUES (1),(2),(3))");
+
+        srv.context().query().querySqlFields(srvSql, false).iterator().hasNext();
+        client.compute().run(() -> client.context().query().querySqlFields(clientSql, false).iterator().hasNext());
+
+        Map<String, Object> expLogins = F.asMap(
+            srvSql.getSql(), srv.context().igniteInstanceName(),
+            clientSql.getSql(), client.context().igniteInstanceName()
+        );
+
+        SystemView<SqlQueryView> views = srv.context().systemView().view(SQL_QRY_VIEW);
+
+        assertEquals(expLogins.size(), views.size());
+
+        for (SqlQueryView view : views) {

Review Comment:
   Added, thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org