[GitHub] [solr] risdenk commented on pull request #1252: SOLR-16598: Upgrade Protobuf to 3.21.12

[GitBox <gi...@apache.org>]

risdenk commented on PR #1252:
URL: https://github.com/apache/solr/pull/1252#issuecomment-1369240914

   So I'm not a fan of putting non Solr direct dependencies in versions.props - basically they will never get removed. We should be upgrading the libraries that use this transitive dependency - which will have the same outcome of using the upgraded protobuf.
   
   PS `com.google.protobuf:protobuf-java*=3.21.12` would probably be better than what was added - this ensures that ALL `protobuf-java` dependencies use the same version instead of just the `protobuf-java-util` dependency.
   
   Was out for the holidays so catching up on stuff.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org