You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "lkishalmi (via GitHub)" <gi...@apache.org> on 2025/11/16 03:11:50 UTC
[PR] Remove Bugtracking Functionality [netbeans]
lkishalmi opened a new pull request, #9020:
URL: https://github.com/apache/netbeans/pull/9020
This one replaces #8396. It removes Mylyn and almost all bugtracking functionality.
I say almost all as there is still a package called `org.netbeans.modules.bugtracking.commons` in `teams.commons` module. I'm bit hesitant to remove that as it is open to friend modules.
Also there are some references in the original IDE JavaHelp HTML files. I think all that old IDE Help shall be removed as a separate cleanup effort.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run?
2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3539219502
Well, all backend implementation needs a friend access, so it is not that hard to check, what is out there.
I've just tried @junichi11 GitHub plugin. While I was able to set up the issue repository in NB28 for NetBeans, nothing else seemed to work. Searching for issues, simply hangs the UI. And reporting a Task hangs it for a while, however was able to open this one: https://github.com/apache/netbeans/issues/9022
Anyway, even if someone would pick these up, the current UI is pretty bloated. It would be better to have a better Issue Tracker specific integration in the IDE. If anyone would be interested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3545330910
i ran a little experiment:
1. checked out this pr
2. switched to felix (which is already bundled and up2date)
3. started, activated all clusters manually via plugins
4. could create a project without exceptions
next, I added https://github.com/mbien/netbeans/commits/bc182/ on top, rebuild and the updated mods did load too.
ergonomics is broken though, that is why I had to manually activate the clusters.
I didn't know how to switch the osgi impl from ancient equinox to felix (both were in the lookup though, felix is at the end since it has no position set). So i hardcoded it as test:
replace Netigso L141:
<details>
```java
Collection<? extends FrameworkFactory> impls = lkp.lookupAll(FrameworkFactory.class);
FrameworkFactory frameworkFactory = new ArrayDeque<>(impls).getLast();
System.out.println("<<<<<<<<<<<");
System.out.println("osgi factory: " + frameworkFactory);
System.out.println("<<<<<<<<<<<");
// FrameworkFactory frameworkFactory = lkp.lookup(FrameworkFactory.class);
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3548718690
> > Removing the ancient broken implementations is fine from my POV, removing the IDE integration points is not.
>
> @matthiasblaesing can you clarify what you mean by "IDE integration points" here? If it's the APIs with friends access, then I don't understand the objection to removing them - they're not official or stable integration points, and should never have been exposed outside of the codebase.
I mean the API/SPI that is exported publicly by `org.netbeans.modules.bugtracking` (`ide/bugtracking`). I'm also talking about `org.netbeans.modules.bugtracking.bridge`, which acts as integration point to SVN/HG/Git.
I see that @junichi11 seems to define friend dependencies on `org.netbeans.modules.bugtracking.commons` for backlog and github plugins. On the other hand the dependencies of that module look harmless.
> i ran a little experiment:
> [...]
> switched to felix (which is already bundled and up2date)
Is this the real reason for the mylyn removal? Dependencies between Mylyn and Equinox?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3537749751
> Have we confirmed that no users are depending on this functionality?
i don't think this matters unless we find a committer who is willing to upgrade mylyn or rewrite the implementation. We have to get rid of technical dept to keep this repo in a maintainable state. Removing it from the UI is not going to help.
There are also some OSGI related tasks we will have to tackle at some point, e.g https://github.com/apache/netbeans/issues/8894 - this cleanup a good chance to make it easier, esp when we would attempt to swap the osgi impl out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3548766375
> Is this the real reason for the mylyn removal? Dependencies between Mylyn and Equinox?
I don't think it is the primary reason, it could be an additional reason though (assuming felix works for NB). My hope was (without taking a closer look first) mylyn removal would make it easier to resolve other issues we had since it pulled very old dependencies. And that seems to be the case. Although I did only very basic testing using felix yesterday + ergonomics didn't work.
But the "plot thickens" so to speak. My guess is that the reason NB ships two osgi impls isn't that someone lost a bet, but rather that the original impl wasn't sufficient for newer usecases it also couldn't be removed due to technical dept - so adding another one seemed like the easier option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3572890822
I'm preparing another PR, which will keep the bugtacking API in the system, though would remove all connectors and Mylyn/Equinox dependency. Would add a new method to the bugtracking API.
How does that sound?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3577063798
> I'm preparing another PR, which will keep the bugtacking API in the system, though would remove all connectors and Mylyn/Equinox dependency. Would add a new method to the bugtracking API.
>
> How does that sound?
Sounds sane to me. From the list of removed modules in this PR I think these should be kept:
- `bugtracking`
- `bugtracking.bridge`
- `bugtracking.commons`
I know, that `bugtracking.commons` is friend-only, but it also has a low dependency count.
I think `localtasks` could be reimplemented without mylyn, but that needs someone to champion that. I would not see removal as a show stopper. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3540732226
> Removing the ancient broken implementations is fine from my POV, removing the IDE integration points is not.
@matthiasblaesing can you clarify what you mean by "IDE integration points" here? If it's the APIs with friends access, then I don't understand the objection to removing them - they're not official or stable integration points, and should never have been exposed outside of the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3548870565
> I mean the API/SPI that is exported publicly by `org.netbeans.modules.bugtracking` (`ide/bugtracking`). I'm also talking about `org.netbeans.modules.bugtracking.bridge`, which acts as integration point to SVN/HG/Git.
Yes, apologies, I'd missed that and confused by the initial comments on this. I have no issue with us dropping (stealth) APIs with external friend access. But, for public exports we should probably deprecate with an eye to removal / no-op in future? I haven't looked at how feasible that is.
> But the "plot thickens" so to speak. My guess is that the reason NB ships two osgi impls isn't that someone lost a bet, but rather that the original impl wasn't sufficient for newer usecases it also couldn't be removed due to technical dept - so adding another one seemed like the easier option.
Equinox was added after Felix for this feature (Mylyn) as far as I know - see https://wiki.apidesign.org/wiki/Netbinox for some background.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3548892693
> Equinox was added after Felix for this feature (Mylyn) as far as I know
I see. Well same result just the other way around ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3541080278
I think the spi is exposed with no need of being friend
https://bits.netbeans.org/dev/javadoc/org-netbeans-modules-bugtracking/org/netbeans/modules/bugtracking/spi/BugtrackingConnector.html
> Under development is a name for a contract that is expected to become a stable API, but that has not yet been finished. The current state serves as a proof of concept, and others are encourage to try it and comment on a dedicated mailing list. Incompatible changes may be done between releases, but should be rare, not radical and properly announced on the mailing list.
I thinks removal should be more carefull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi closed pull request #9020: Remove Bugtracking Functionality
URL: https://github.com/apache/netbeans/pull/9020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3537684100
Have we confirmed that no users are depending on this functionality?
One way to do so is to just remove the relevant menu items for one release, and see if anyone complains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3538130760
> Removing it from the UI is not going to help.
Understood, it's just a more cautious way to proceed, since feature removal tends to be a "one-way" decision. I.e. first find out if the feature is being used, then proceed to remove the implementation code if not. Or, if there are actual users, have the longer discussion about whether it should still be removed or not.
But in this case I suspect the feature really does not have much current use, so it sounds fine to remove it in one go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove Bugtracking Functionality [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #9020:
URL: https://github.com/apache/netbeans/pull/9020#issuecomment-3539317544
> Well, all backend implementation needs a friend access, so it is not that hard to check, what is out there.
Last time I had a look at Mantis Integration (I created that as a Proof-of-Concept) it did not have implementation or friend dependencies.
> I've just tried @junichi11 GitHub plugin. While I was able to set up the issue repository in NB28 for NetBeans, nothing else seemed to work. Searching for issues, simply hangs the UI. And reporting a Task hangs it for a while, however was able to open this one: #9022
Created repository connection, created task in a separate test repository, searched tasks in Apache Netbeans, opened an existing issue from Apache NetBeans in the IDE. It is slow and work is done on the EDT, that should be in the background, but it still works.
> Anyway, even if someone would pick these up, the current UI is pretty bloated. It would be better to have a better Issue Tracker specific integration in the IDE. If anyone would be interested.
Removing the ancient broken implementations is fine from my POV, removing the IDE integration points is not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists