You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2023/02/10 23:54:48 UTC

[GitHub] [pinot] Jackie-Jiang commented on pull request #10260: Relax the constraint to have a dictionary and inverted index when forward index is disabled

Jackie-Jiang commented on PR #10260:
URL: https://github.com/apache/pinot/pull/10260#issuecomment-1426505319

   > We have a scenario where the dictionary can be disabled for a forward index disabled column. For such scenarios we don't handle anything on reload today. Are you saying that even for toggling whether the dictionary is enabled or disabled we should just treat reload as a no-op rather than throwing error? What about indexes like the range index that need to be modified when the column has the dictionary enabled or disabled?
   
   Disable dictionary should be independent of disabling forward index. Currently it is no-op because we want to ensure data can be recovered. With the new change, we should allow no dictionary + no forward index. Note that disable dictionary + enable inverted index is invalid config, and we should reject it during table config validation.
   When both forward index and dictionary are disabled, no further index modification is allowed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org