You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Jaideep dhok <ja...@inmobi.com> on 2015/02/26 13:49:50 UTC

Re: Review Request 31485: LENS-359 Set correct class loader on query conf in LensService.getLensConf

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31485/
-----------------------------------------------------------

(Updated Feb. 26, 2015, 12:49 p.m.)


Review request for lens and Amareshwari Sriramadasu.


Summary (updated)
-----------------

LENS-359 Set correct class loader on query conf in LensService.getLensConf


Bugs: lens-359
    https://issues.apache.org/jira/browse/lens-359


Repository: lens


Description
-------

LENS-359 Set correct class loader on query conf in LensService.getLensConf


Diffs
-----

  lens-server/src/main/java/org/apache/lens/server/LensService.java 14b7b19afb15195cc874499d5e895c9067d848fa 
  lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java cce0883c937f8937f3e7c1c90c59f930c479ffe8 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 2d4619b96192a514f25415dfb8280d94dd4f32ea 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 31738b5bf5d83f8c197d1c183bb8563390cb0a00 

Diff: https://reviews.apache.org/r/31485/diff/


Testing
-------

Added asserts for query context class loader.

Will update test results


Thanks,

Jaideep dhok


Re: Review Request 31485: LENS-359 Set correct class loader on query conf in LensService.getLensConf

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31485/#review74262
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Feb. 26, 2015, 12:49 p.m., Jaideep dhok wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31485/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 12:49 p.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: lens-359
>     https://issues.apache.org/jira/browse/lens-359
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-359 Set correct class loader on query conf in LensService.getLensConf
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/LensService.java 14b7b19afb15195cc874499d5e895c9067d848fa 
>   lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java cce0883c937f8937f3e7c1c90c59f930c479ffe8 
>   lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 2d4619b96192a514f25415dfb8280d94dd4f32ea 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 31738b5bf5d83f8c197d1c183bb8563390cb0a00 
> 
> Diff: https://reviews.apache.org/r/31485/diff/
> 
> 
> Testing
> -------
> 
> Added asserts for query context class loader.
> 
> Will update test results
> 
> 
> Thanks,
> 
> Jaideep dhok
> 
>


Re: Review Request 31485: LENS-359 Set correct class loader on query conf in LensService.getLensConf

Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31485/
-----------------------------------------------------------

(Updated Feb. 26, 2015, 1:05 p.m.)


Review request for lens and Amareshwari Sriramadasu.


Bugs: lens-359
    https://issues.apache.org/jira/browse/lens-359


Repository: lens


Description
-------

LENS-359 Set correct class loader on query conf in LensService.getLensConf


Diffs
-----

  lens-server/src/main/java/org/apache/lens/server/LensService.java 14b7b19afb15195cc874499d5e895c9067d848fa 
  lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java cce0883c937f8937f3e7c1c90c59f930c479ffe8 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 2d4619b96192a514f25415dfb8280d94dd4f32ea 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 31738b5bf5d83f8c197d1c183bb8563390cb0a00 

Diff: https://reviews.apache.org/r/31485/diff/


Testing (updated)
-------

Added asserts for query context class loader.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.222s]
[INFO] Lens .............................................. SUCCESS [1.952s]
[INFO] Lens API .......................................... SUCCESS [5.719s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.436s]
[INFO] Lens Cube ......................................... SUCCESS [6:31.146s]
[INFO] Lens DB storage ................................... SUCCESS [9.784s]
[INFO] Lens Query Library ................................ SUCCESS [4.414s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:33.919s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [25.871s]
[INFO] Lens Server ....................................... SUCCESS [4:30.224s]
[INFO] Lens client ....................................... SUCCESS [20.861s]
[INFO] Lens CLI .......................................... SUCCESS [1:41.944s]
[INFO] Lens Examples ..................................... SUCCESS [0.864s]
[INFO] Lens Distribution ................................. SUCCESS [11.095s]
[INFO] Lens ML Lib ....................................... SUCCESS [47.862s]
[INFO] Lens Regression ................................... SUCCESS [0.489s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:34.847s
[INFO] Finished at: Thu Feb 26 13:04:27 UTC 2015
[INFO] Final Memory: 100M/996M
[INFO] ------------------------------------------------------------------------


Thanks,

Jaideep dhok