You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2013/05/17 04:00:21 UTC
Review Request: WDRF 4 - Add WDRFSorter and Sorter::setWeight
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11212/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Description
-------
Adds a WDRFSorter class and a setWeight function in Sorter.
Diffs
-----
src/Makefile.am 343a7c5
src/master/drf_sorter.hpp 79566cc
src/master/hierarchical_allocator_process.hpp 2422fbd
src/master/sorter.hpp 73db6b1
src/master/wdrf_sorter.hpp PRE-CREATION
src/master/wdrf_sorter.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/11212/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: WDRF 4 - Add weighting to DRFSorter
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11212/
-----------------------------------------------------------
(Updated June 13, 2013, 7:28 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Ben's review - removed setWeight in favor of passing weights in during add. Elimantes questions of what it means to change a weight.
Summary (updated)
-----------------
WDRF 4 - Add weighting to DRFSorter
Description
-------
Adds a WDRFSorter class and a setWeight function in Sorter.
This addresses bug MESOS-504.
https://issues.apache.org/jira/browse/MESOS-504
Diffs (updated)
-----
src/master/drf_sorter.hpp 866515e
src/master/drf_sorter.cpp 7fcd0ca
src/master/hierarchical_allocator_process.hpp 1048a28
src/master/sorter.hpp e54be3b
Diff: https://reviews.apache.org/r/11212/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: WDRF 4 - Add weighting to DRFSorter with
Sorter::setWeight
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11212/
-----------------------------------------------------------
(Updated June 12, 2013, 11:40 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Added bug.
Description
-------
Adds a WDRFSorter class and a setWeight function in Sorter.
This addresses bug MESOS-504.
https://issues.apache.org/jira/browse/MESOS-504
Diffs
-----
src/master/drf_sorter.hpp 866515e
src/master/drf_sorter.cpp 7fcd0ca
src/master/hierarchical_allocator_process.hpp 1048a28
src/master/sorter.hpp e54be3b
Diff: https://reviews.apache.org/r/11212/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: WDRF 4 - Add weighting to DRFSorter with
Sorter::setWeight
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11212/#review21825
-----------------------------------------------------------
Ship it!
src/master/drf_sorter.cpp
<https://reviews.apache.org/r/11212/#comment45079>
If we just passed the weight initially from Master::initialize we could just set the weight once and for all and have no need for 'setWeight'.
- Benjamin Hindman
On June 5, 2013, 9:41 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11212/
> -----------------------------------------------------------
>
> (Updated June 5, 2013, 9:41 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> Adds a WDRFSorter class and a setWeight function in Sorter.
>
>
> Diffs
> -----
>
> src/master/drf_sorter.hpp 866515e
> src/master/drf_sorter.cpp 7fcd0ca
> src/master/hierarchical_allocator_process.hpp 1048a28
> src/master/sorter.hpp e54be3b
>
> Diff: https://reviews.apache.org/r/11212/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: WDRF 4 - Add weighting to DRFSorter with
Sorter::setWeight
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11212/
-----------------------------------------------------------
(Updated June 5, 2013, 9:41 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Updated from discussion with Ben H:
- I removed the WDRFSorter and instead put weighting into DRFSorter with a default weight of 1.
- I removed setting weights for frameworks, as we decided that role level weighting is sufficient for now until we decide on an appropriate way for framework weights to be specified.
- I fixed a bug in DRFSorter where an inactive framework could be inadvertently reactivated if it has resources allocated or unallocated to it.
Summary (updated)
-----------------
WDRF 4 - Add weighting to DRFSorter with Sorter::setWeight
Description
-------
Adds a WDRFSorter class and a setWeight function in Sorter.
Diffs (updated)
-----
src/master/drf_sorter.hpp 866515e
src/master/drf_sorter.cpp 7fcd0ca
src/master/hierarchical_allocator_process.hpp 1048a28
src/master/sorter.hpp e54be3b
Diff: https://reviews.apache.org/r/11212/diff/
Testing
-------
make check
Thanks,
Thomas Marshall