You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/02 15:51:01 UTC

[GitHub] [airflow] shahkshitij15 opened a new pull request #21944: Added autodetect parameter in external table creation using GCS to BQ…

shahkshitij15 opened a new pull request #21944:
URL: https://github.com/apache/airflow/pull/21944


   … operator
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #21801 
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   Added autodetect in external table creation for GCS to BQ operator
   Now one can create the external table without passing any schema
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21944: Added autodetect parameter in external table creation using GCS to BQ…

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21944:
URL: https://github.com/apache/airflow/pull/21944#issuecomment-1057081828


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] shahkshitij15 edited a comment on pull request #21944: Add autodetect arg to external table creation in GCS-to-BQ operator

Posted by GitBox <gi...@apache.org>.
shahkshitij15 edited a comment on pull request #21944:
URL: https://github.com/apache/airflow/pull/21944#issuecomment-1061832671


   Hey! With reference to issue #22063, how shall I test the proper working of my code? @potiuk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21944: Add autodetect arg to external table creation in GCS-to-BQ operator

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21944:
URL: https://github.com/apache/airflow/pull/21944#issuecomment-1059934917


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #21944: Add autodetect arg to external table creation in GCS-to-BQ operator

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21944:
URL: https://github.com/apache/airflow/pull/21944#issuecomment-1061847797


   Improved instructions added in PR https://github.com/apache/airflow/pull/22087


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #21944: Add autodetect arg to external table creation in GCS-to-BQ operator

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21944:
URL: https://github.com/apache/airflow/pull/21944#issuecomment-1057847897


   Tests are failing @shahkshitij15 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] shahkshitij15 edited a comment on pull request #21944: Add autodetect arg to external table creation in GCS-to-BQ operator

Posted by GitBox <gi...@apache.org>.
shahkshitij15 edited a comment on pull request #21944:
URL: https://github.com/apache/airflow/pull/21944#issuecomment-1058086013


   Hey! I have updated the test cases. Now it should work @potiuk 
   Please approve @turbaszek 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #21944: Add autodetect arg to external table creation in GCS-to-BQ operator

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21944:
URL: https://github.com/apache/airflow/pull/21944#issuecomment-1061835834


   Here you can find some helpful guidelines:  https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PROVIDER_PACKAGES.md#verify-by-contributors


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #21944: Add autodetect arg to external table creation in GCS-to-BQ operator

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21944:
URL: https://github.com/apache/airflow/pull/21944#issuecomment-1057715626


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal merged pull request #21944: Add autodetect arg to external table creation in GCS-to-BQ operator

Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #21944:
URL: https://github.com/apache/airflow/pull/21944


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] shahkshitij15 commented on pull request #21944: Add autodetect arg to external table creation in GCS-to-BQ operator

Posted by GitBox <gi...@apache.org>.
shahkshitij15 commented on pull request #21944:
URL: https://github.com/apache/airflow/pull/21944#issuecomment-1058086013


   Hey! I have updated the test cases. Now it should work @potiuk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] shahkshitij15 commented on pull request #21944: Add autodetect arg to external table creation in GCS-to-BQ operator

Posted by GitBox <gi...@apache.org>.
shahkshitij15 commented on pull request #21944:
URL: https://github.com/apache/airflow/pull/21944#issuecomment-1061832671


   Hey! With reference to issue #22063, how shall I test the proper working of my code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org