You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/10/11 19:06:00 UTC
[jira] [Commented] (GEODE-9629)
GatewaySender.setRetriesToGetTransactionEventsFromQueue on public API
[ https://issues.apache.org/jira/browse/GEODE-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427332#comment-17427332 ]
ASF subversion and git services commented on GEODE-9629:
--------------------------------------------------------
Commit 956db9ce86ec1e93913c3f6feda21b8023de3816 in geode's branch refs/heads/develop from Owen Nichols
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=956db9c ]
GEODE-9629: previous fix missed removing this other public getter that broke compatibility (#6972)
> GatewaySender.setRetriesToGetTransactionEventsFromQueue on public API
> ---------------------------------------------------------------------
>
> Key: GEODE-9629
> URL: https://issues.apache.org/jira/browse/GEODE-9629
> Project: Geode
> Issue Type: Improvement
> Components: wan
> Affects Versions: 1.15.0
> Reporter: Udo Kohlmeyer
> Priority: Blocker
> Labels: needsTriage, pull-request-available
> Fix For: 1.15.0
>
>
> GatewaySender.setRetriesToGetTransactionEventsFromQueue is defined on the public API.
> The problem with this is that Geode should not allow for the simple modification of settings for a GatewaySender. Without proper process / management around the changing of the properties it would be too simple to introduce side-effects by changing settings on the GatewaySender.
> We (Geode) should NOT allow for the direct manipulation of configuration of ANY component without it having gone through a controlled process, to ensure that there aren't any side effects resulting from the change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)