[GitHub] [camel-k] squakez commented on a diff in pull request #4633: Fix cron trait doc, timer usage is missing information

["squakez (via GitHub)" <gi...@apache.org>]

squakez commented on code in PR #4633:
URL: https://github.com/apache/camel-k/pull/4633#discussion_r1281464949


##########
pkg/apis/camel/v1/trait/cron.go:
##########
@@ -27,8 +27,11 @@ package trait
 // Integrations that start from the following components are evaluated by the cron trait: `timer`, `cron`, `quartz`.
 //
 // The rules for using a Kubernetes CronJob are the following:
-//   - `timer`: when periods can be written as cron expressions. E.g. `timer:tick?period=60000`.
+//
+//   - `timer`: when period is set in milliseconds with no remaining seconds, for example 120000. If there is any second left as in 121000 (120s and 1s) or the presence of any of these parameters (delay, repeatCount, time) then a CronJob  won't be created, but a standard deployment.

Review Comment:
   Just out of curiosity. Where is this behavior defined? in the runtime?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org