apache V0.8.8 under Linux (fwd)

[Rob Hartill <ha...@hyperreal.com>]

Not a bug, but one of our Linux gurus might want to check it or ignore it.


Forwarded message:
> Date: Wed, 16 Aug 1995 18:42:35 -0400
> From: root <ro...@linux.sjs.com>
> To: apache-bugs@apache.org
> Subject: apache V0.8.8 under Linux
> 
> I just thought you might want to know that I compiled Apache V0.8.8 with Linux
> kernel V1.2.11 and Gcc V2.7.0 and got this one compiler warning:
> 
> gcc -c -O2 -DLINUX mod_access.c
> mod_access.c: In function `create_access_dir_config':
> mod_access.c:96: warning: assignment makes integer from pointer without a cast
> 
> 	The daemon seems to work ok.
> 
> 	Steve Stuczynski
> 	Systems & Network Consultant
> e-mail: steve@sjs.com
> URL:    http://www.sjs.com
>  
> 

Re: apache V0.8.8 under Linux (fwd)

["James H. Cloos Jr." <cl...@io.com>]

|> Not a bug, but one of our Linux gurus might want to check it or
|> ignore it.


|> Forwarded message:

>> gcc -c -O2 -DLINUX mod_access.c mod_access.c: In function
>> `create_access_dir_config': mod_access.c:96: warning: assignment
>> makes integer from pointer without a cast

NULL is defined as ((void *) 0) in the GNU libc headers.
Line 96 of mod_access.c contains conf->order[i] = NULL,
where conf->order is a int.

The patch would be:

--- mod_access.c-dist   Thu Aug 17 02:14:07 1995
+++ mod_access.c        Thu Aug 17 02:14:28 1995
@@ -93,7 +93,7 @@
         (access_dir_conf *)pcalloc(p, sizeof(access_dir_conf));
     int i;
     
-    for (i = 0; i < METHODS; ++i) conf->order[i] = NULL;
+    for (i = 0; i < METHODS; ++i) conf->order[i] = (int)NULL;
     conf->allows = make_array (p, 1, sizeof (allowdeny));
     conf->denys = make_array (p, 1, sizeof (allowdeny));
     

-JimC
-- 
James H. Cloos, Jr.	Snail:	POBox 18122 Austin, TX 78760-8122   Usenix,SAGE
cloos@io.com		URL:	http://www.jhcloos.com/~cloos/      LPF