You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/04/17 00:06:31 UTC
Review Request 20428: Add Containerizer::containers() to get set of
containers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20428/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Repository: mesos-git
Description
-------
This is needed for an upcoming patch to improve clean up in tests.
Diffs
-----
src/slave/containerizer/containerizer.hpp d9ae326f41613149de2ab3f6a5b5a19c655029a3
src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
src/slave/containerizer/mesos_containerizer.cpp 1ce41d71eb13582b46d240d48f0508bdc3e7ef10
src/tests/containerizer.hpp a9f15318803aeb41489a48d7e9e94caa97d71456
src/tests/containerizer.cpp bfb93412b801a24ac77bf621d55ebb00bfd4fdd7
Diff: https://reviews.apache.org/r/20428/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 20428: Add Containerizer::containers() to get set of
containers.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20428/
-----------------------------------------------------------
(Updated April 23, 2014, 11:59 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, Jason Dusek, Till Toenshoff, and Vinod Kone.
Changes
-------
Rebased.
Repository: mesos-git
Description
-------
This is needed for an upcoming patch to improve clean up in tests.
Diffs (updated)
-----
src/slave/containerizer/containerizer.hpp b4196d4c16195ab21e5a21c2ad92f0426b474e71
src/slave/containerizer/mesos_containerizer.hpp c3d08d9df11a3de7c8be6dd44fd6683005197e02
src/slave/containerizer/mesos_containerizer.cpp 20e8d2e2490abad6a350cb229a5202972f15f436
src/tests/containerizer.hpp 5a522fcdc9ee2dcfd372da403518538160cf7fe5
src/tests/containerizer.cpp 601d5325b0248376ea48a309faf583e668b87296
Diff: https://reviews.apache.org/r/20428/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 20428: Add Containerizer::containers() to get set of
containers.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20428/#review41219
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 21, 2014, 9:23 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20428/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 9:23 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, Jason Dusek, Till Toenshoff, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is needed for an upcoming patch to improve clean up in tests.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp d9ae326f41613149de2ab3f6a5b5a19c655029a3
> src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
> src/slave/containerizer/mesos_containerizer.cpp 1ce41d71eb13582b46d240d48f0508bdc3e7ef10
> src/tests/containerizer.hpp a9f15318803aeb41489a48d7e9e94caa97d71456
> src/tests/containerizer.cpp bfb93412b801a24ac77bf621d55ebb00bfd4fdd7
>
> Diff: https://reviews.apache.org/r/20428/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20428: Add Containerizer::containers() to get set of
containers.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20428/
-----------------------------------------------------------
(Updated April 21, 2014, 9:23 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, Jason Dusek, Till Toenshoff, and Vinod Kone.
Changes
-------
Switched from std::set to hashset.
Repository: mesos-git
Description
-------
This is needed for an upcoming patch to improve clean up in tests.
Diffs (updated)
-----
src/slave/containerizer/containerizer.hpp d9ae326f41613149de2ab3f6a5b5a19c655029a3
src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
src/slave/containerizer/mesos_containerizer.cpp 1ce41d71eb13582b46d240d48f0508bdc3e7ef10
src/tests/containerizer.hpp a9f15318803aeb41489a48d7e9e94caa97d71456
src/tests/containerizer.cpp bfb93412b801a24ac77bf621d55ebb00bfd4fdd7
Diff: https://reviews.apache.org/r/20428/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 20428: Add Containerizer::containers() to get set of
containers.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20428/
-----------------------------------------------------------
(Updated April 17, 2014, 5:35 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, Jason Dusek, Till Toenshoff, and Vinod Kone.
Changes
-------
Added Till and Jason.
Repository: mesos-git
Description
-------
This is needed for an upcoming patch to improve clean up in tests.
Diffs
-----
src/slave/containerizer/containerizer.hpp d9ae326f41613149de2ab3f6a5b5a19c655029a3
src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
src/slave/containerizer/mesos_containerizer.cpp 1ce41d71eb13582b46d240d48f0508bdc3e7ef10
src/tests/containerizer.hpp a9f15318803aeb41489a48d7e9e94caa97d71456
src/tests/containerizer.cpp bfb93412b801a24ac77bf621d55ebb00bfd4fdd7
Diff: https://reviews.apache.org/r/20428/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 20428: Add Containerizer::containers() to get set of
containers.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20428/#review40609
-----------------------------------------------------------
Ship it!
src/slave/containerizer/containerizer.hpp
<https://reviews.apache.org/r/20428/#comment73644>
s/std::set/hashset/ ?
- Vinod Kone
On April 16, 2014, 10:06 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20428/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 10:06 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is needed for an upcoming patch to improve clean up in tests.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp d9ae326f41613149de2ab3f6a5b5a19c655029a3
> src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
> src/slave/containerizer/mesos_containerizer.cpp 1ce41d71eb13582b46d240d48f0508bdc3e7ef10
> src/tests/containerizer.hpp a9f15318803aeb41489a48d7e9e94caa97d71456
> src/tests/containerizer.cpp bfb93412b801a24ac77bf621d55ebb00bfd4fdd7
>
> Diff: https://reviews.apache.org/r/20428/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20428: Add Containerizer::containers() to get set of
containers.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20428/#review40663
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20428]
All tests passed.
- Mesos ReviewBot
On April 16, 2014, 10:06 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20428/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 10:06 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is needed for an upcoming patch to improve clean up in tests.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp d9ae326f41613149de2ab3f6a5b5a19c655029a3
> src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
> src/slave/containerizer/mesos_containerizer.cpp 1ce41d71eb13582b46d240d48f0508bdc3e7ef10
> src/tests/containerizer.hpp a9f15318803aeb41489a48d7e9e94caa97d71456
> src/tests/containerizer.cpp bfb93412b801a24ac77bf621d55ebb00bfd4fdd7
>
> Diff: https://reviews.apache.org/r/20428/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20428: Add Containerizer::containers() to get set of
containers.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20428/#review40664
-----------------------------------------------------------
It probably makes sense to include folks like Till and/or Jason in these reviews too as they're working on Containerizer implementations.
- Benjamin Hindman
On April 16, 2014, 10:06 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20428/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 10:06 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is needed for an upcoming patch to improve clean up in tests.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp d9ae326f41613149de2ab3f6a5b5a19c655029a3
> src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
> src/slave/containerizer/mesos_containerizer.cpp 1ce41d71eb13582b46d240d48f0508bdc3e7ef10
> src/tests/containerizer.hpp a9f15318803aeb41489a48d7e9e94caa97d71456
> src/tests/containerizer.cpp bfb93412b801a24ac77bf621d55ebb00bfd4fdd7
>
> Diff: https://reviews.apache.org/r/20428/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>