[GitHub] [spark] xinrong-meng commented on a diff in pull request #39860: Standardize registered pickled Python UDFs

["xinrong-meng (via GitHub)" <gi...@apache.org>]

xinrong-meng commented on code in PR #39860:
URL: https://github.com/apache/spark/pull/39860#discussion_r1094445683


##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -33,6 +34,7 @@ message Command {
     CreateScalarFunction create_function = 1;
     WriteOperation write_operation = 2;
     CreateDataFrameViewCommand create_dataframe_view = 3;
+    CommonInlineUserDefinedFunction register_function = 4;

Review Comment:
   I would suggest renaming `CommonInlineUserDefinedFunction` to `CommonUserDefinedFunction` since both registered and inline-defined pickled Python UDFs may share the same proto. CC @HyukjinKwon @zhengruifeng @grundprinzip @hvanhovell 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org