You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "atsteffen (via GitHub)" <gi...@apache.org> on 2023/02/23 18:36:37 UTC

[GitHub] [maven-build-cache-extension] atsteffen commented on a diff in pull request #43: [MBUILDCACHE-46] Add maven.build.cache.remote.enabled parameter

atsteffen commented on code in PR #43:
URL: https://github.com/apache/maven-build-cache-extension/pull/43#discussion_r1116098085


##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -452,7 +453,9 @@ public boolean isEnabled() {
     @Override
     public boolean isRemoteCacheEnabled() {
         checkInitializedState();
-        return getRemote().getUrl() != null && getRemote().isEnabled();
+        return getRemote().getUrl() != null
+                && Boolean.parseBoolean(System.getProperty(

Review Comment:
   Thanks!  I went ahead and updated a couple other Boolean.getProperty(..) methods as those also go to the system properties.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org