You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/12/08 17:46:39 UTC
[GitHub] [superset] codyml commented on a diff in pull request #22364: feat(dashboard): Add edit button to dashboard native filters filter cards
codyml commented on code in PR #22364:
URL: https://github.com/apache/superset/pull/22364#discussion_r1043646724
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/FilterCard.test.tsx:
##########
@@ -204,6 +205,13 @@ jest.mock('@superset-ui/core', () => ({
}),
}));
+jest.mock(
Review Comment:
I thought this is what you had to add to avoid `act` warnings when running tests – without it all of the tests output a bunch of `act` icon errors. @michael-s-molina I know you worked on this, is this still the best case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org