You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/09/17 05:53:58 UTC
[GitHub] [kafka] ableegoldman opened a new pull request #11332: MINOR: re-add removed test coverage for 'KAFKA-12983: reset needsJoinPrepare flag'
ableegoldman opened a new pull request #11332:
URL: https://github.com/apache/kafka/pull/11332
In [11231](https://github.com/apache/kafka/pull/11231) we fixed a bug in which the consumer would reset its state unnecessarily, and fixed up the tests accordingly. Unfortunately this also wiped out the test coverage for https://issues.apache.org/jira/browse/KAFKA-12983 that was added in [10986](https://github.com/apache/kafka/pull/10986).
I noticed this when cherrypicking that fix back to the 2.7 branch and hitting merge conflicts in the test. I moved/replaced the test coverage for KAFKA-12983 in the cherrypicked fix, so we should now port this forward to the newer branches.
Should be cherrypicked back to 2.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11332: MINOR: re-add removed test coverage for 'KAFKA-12983: reset needsJoinPrepare flag'
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11332:
URL: https://github.com/apache/kafka/pull/11332#issuecomment-937381455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11332: MINOR: re-add removed test coverage for 'KAFKA-12983: reset needsJoinPrepare flag'
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11332:
URL: https://github.com/apache/kafka/pull/11332#issuecomment-937381455
Failures are unrelated:
`kafka.admin.LeaderElectionCommandTest.testElectionResultOutput()`
`kafka.api.PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #11332: MINOR: re-add removed test coverage for 'KAFKA-12983: reset needsJoinPrepare flag'
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #11332:
URL: https://github.com/apache/kafka/pull/11332#discussion_r711015259
##########
File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java
##########
@@ -2830,14 +2831,17 @@ public void testConsumerRejoinAfterRebalance() {
// Retry join should then succeed
client.respond(joinGroupFollowerResponse(generationId, memberId, "leader", Errors.NONE));
- client.prepareResponse(syncGroupResponse(singletonList(t1p), Errors.NONE));
+ client.prepareResponse(syncGroupResponse(partitions, Errors.NONE));
res = coordinator.joinGroupIfNeeded(time.timer(3000));
assertTrue(res);
assertFalse(client.hasPendingResponses());
assertFalse(client.hasInFlightRequests());
}
+ Collection<TopicPartition> lost = getLost(partitions);
+ assertEquals(lost.isEmpty() ? 0 : 1, rebalanceListener.lostCount);
Review comment:
I think I would move this assert below (since it provides less information than the other one) and have it like:
```java
assertEquals(lost.size(), rebalanceListener.lostCount);
```
Would that work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #11332: MINOR: re-add removed test coverage for 'KAFKA-12983: reset needsJoinPrepare flag'
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #11332:
URL: https://github.com/apache/kafka/pull/11332#discussion_r711696755
##########
File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java
##########
@@ -2830,14 +2831,17 @@ public void testConsumerRejoinAfterRebalance() {
// Retry join should then succeed
client.respond(joinGroupFollowerResponse(generationId, memberId, "leader", Errors.NONE));
- client.prepareResponse(syncGroupResponse(singletonList(t1p), Errors.NONE));
+ client.prepareResponse(syncGroupResponse(partitions, Errors.NONE));
res = coordinator.joinGroupIfNeeded(time.timer(3000));
assertTrue(res);
assertFalse(client.hasPendingResponses());
assertFalse(client.hasInFlightRequests());
}
+ Collection<TopicPartition> lost = getLost(partitions);
+ assertEquals(lost.isEmpty() ? 0 : 1, rebalanceListener.lostCount);
Review comment:
Will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11332: MINOR: re-add removed test coverage for 'KAFKA-12983: reset needsJoinPrepare flag'
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11332:
URL: https://github.com/apache/kafka/pull/11332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11332: MINOR: re-add removed test coverage for 'KAFKA-12983: reset needsJoinPrepare flag'
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11332:
URL: https://github.com/apache/kafka/pull/11332#issuecomment-937385978
Merged to trunk and cherrypicked to 3.0 & 2.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11332: MINOR: re-add removed test coverage for 'KAFKA-12983: reset needsJoinPrepare flag'
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11332:
URL: https://github.com/apache/kafka/pull/11332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org