You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/07/03 00:24:18 UTC

[kudu-CR] [rebalancer] 'auto' mode for RF=1 tablet movements

Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10612

to look at the new patch set (#10).

Change subject: [rebalancer] 'auto' mode for RF=1 tablet movements
......................................................................

[rebalancer] 'auto' mode for RF=1 tablet movements

Added logic to automatically determine whether the tool should
move replicas of tablets with RF=1. This is determined by examining the
version of Kudu and the replica management schema in the cluster, which
indicates whether the fix for KUDU-2443 applies. The fix applies
whenever the version is larger than 1.7.0.

This patch also contains a unit test for the newly introduced
Is343SchemeCluster() utility function.

The existing RebalanceParamTest provides coverage in case of
--move_single_replicas=auto (the default setting for the flag).

Change-Id: Id5a06b137cb34d9351f7e2fb819ed52790e2ee7e
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/rebalance-test.cc
M src/kudu/tools/rebalancer.h
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_replica_util.cc
M src/kudu/tools/tool_replica_util.h
7 files changed, 386 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/10612/10
-- 
To view, visit http://gerrit.cloudera.org:8080/10612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5a06b137cb34d9351f7e2fb819ed52790e2ee7e
Gerrit-Change-Number: 10612
Gerrit-PatchSet: 10
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>