You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/11/15 06:32:29 UTC

Review Request 63825: KYLIN-3042: In query results page, the results data table should resize when click "fullscreen" button

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63825/
-----------------------------------------------------------

Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Bugs: KYLIN-3042
    https://issues.apache.org/jira/browse/KYLIN-3042


Repository: kylin


Description
-------

1.Do a new query in query page;
2.Then click "fullscreen" button in query results page below;
3.After the fullscreen results page shows, we can see that the size of data table is much smaller than its parent frame.
So we hope that the results data table will resize when click "fullScreen" button.


Diffs
-----

  webapp/app/js/directives/ui-grid.js 352e919a4 


Diff: https://reviews.apache.org/r/63825/diff/1/


Testing
-------


Thanks,

pengjianhua


Re: Review Request 63825: KYLIN-3042: In query results page, the results data table should resize when click "fullscreen" button

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63825/
-----------------------------------------------------------

(Updated 十一月 15, 2017, 6:59 a.m.)


Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Changes
-------

format


Bugs: KYLIN-3042
    https://issues.apache.org/jira/browse/KYLIN-3042


Repository: kylin


Description
-------

1.Do a new query in query page;
2.Then click "fullscreen" button in query results page below;
3.After the fullscreen results page shows, we can see that the size of data table is much smaller than its parent frame.
So we hope that the results data table will resize when click "fullScreen" button.


Diffs (updated)
-----

  webapp/app/js/directives/ui-grid.js 352e919a4 


Diff: https://reviews.apache.org/r/63825/diff/3/

Changes: https://reviews.apache.org/r/63825/diff/2-3/


Testing
-------


Thanks,

pengjianhua


Re: Review Request 63825: KYLIN-3042: In query results page, the results data table should resize when click "fullscreen" button

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63825/
-----------------------------------------------------------

(Updated 十一月 15, 2017, 6:42 a.m.)


Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Bugs: KYLIN-3042
    https://issues.apache.org/jira/browse/KYLIN-3042


Repository: kylin


Description
-------

1.Do a new query in query page;
2.Then click "fullscreen" button in query results page below;
3.After the fullscreen results page shows, we can see that the size of data table is much smaller than its parent frame.
So we hope that the results data table will resize when click "fullScreen" button.


Diffs (updated)
-----

  webapp/app/js/directives/ui-grid.js 352e919a4 


Diff: https://reviews.apache.org/r/63825/diff/2/

Changes: https://reviews.apache.org/r/63825/diff/1-2/


Testing
-------


Thanks,

pengjianhua