You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "no1wudi (via GitHub)" <gi...@apache.org> on 2023/05/17 09:57:32 UTC

[GitHub] [nuttx-apps] no1wudi opened a new pull request, #1761: tools: Disable wasm build if toolchain not found

no1wudi opened a new pull request, #1761:
URL: https://github.com/apache/nuttx-apps/pull/1761

   ## Summary
   tools: Disable wasm build if toolchain not found
   ## Impact
   wasm build only
   ## Testing
   CI and local machine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1761: tools: Disable wasm build if toolchain not found

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1761:
URL: https://github.com/apache/nuttx-apps/pull/1761#discussion_r1198896625


##########
tools/Wasm.mk:
##########
@@ -24,7 +24,17 @@ include $(APPDIR)$(DELIM)interpreters$(DELIM)wamr$(DELIM)Toolchain.defs
 # wasi-sdk toolchain setting
 
 WCC ?= $(WASI_SDK_PATH)/bin/clang
-WAR ?= $(WASI_SDK_PATH)/bin/llvm-ar rcs
+WAR ?= $(WASI_SDK_PATH)/bin/llvm-ar

Review Comment:
   so should we enable wasm build until some app want to output wasm module?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1761: tools: Disable wasm build if toolchain not found

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #1761:
URL: https://github.com/apache/nuttx-apps/pull/1761


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] no1wudi commented on a diff in pull request #1761: tools: Disable wasm build if toolchain not found

Posted by "no1wudi (via GitHub)" <gi...@apache.org>.
no1wudi commented on code in PR #1761:
URL: https://github.com/apache/nuttx-apps/pull/1761#discussion_r1197248351


##########
tools/Wasm.mk:
##########
@@ -24,7 +24,17 @@ include $(APPDIR)$(DELIM)interpreters$(DELIM)wamr$(DELIM)Toolchain.defs
 # wasi-sdk toolchain setting
 
 WCC ?= $(WASI_SDK_PATH)/bin/clang
-WAR ?= $(WASI_SDK_PATH)/bin/llvm-ar rcs
+WAR ?= $(WASI_SDK_PATH)/bin/llvm-ar

Review Comment:
   Here is the first place, Wasm.mk is introduced by Application.mk.
   
   I think check it by toolchain is better, there is a case that enable a wasm interpreter but don't want to build wasm app from nuttx repo (some apps enabled WASM_BUILD by default).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1761: tools: Disable wasm build if toolchain not found

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #1761:
URL: https://github.com/apache/nuttx-apps/pull/1761#issuecomment-1554491751

   @acassis please try this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1761: tools: Disable wasm build if toolchain not found

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1761:
URL: https://github.com/apache/nuttx-apps/pull/1761#discussion_r1196800469


##########
tools/Wasm.mk:
##########
@@ -24,7 +24,17 @@ include $(APPDIR)$(DELIM)interpreters$(DELIM)wamr$(DELIM)Toolchain.defs
 # wasi-sdk toolchain setting
 
 WCC ?= $(WASI_SDK_PATH)/bin/clang
-WAR ?= $(WASI_SDK_PATH)/bin/llvm-ar rcs
+WAR ?= $(WASI_SDK_PATH)/bin/llvm-ar

Review Comment:
   but should we disable wasm build if nobody enables wasm related config in the first place?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org