You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/26 07:09:38 UTC
[GitHub] [incubator-doris] vagetablechicken opened a new issue #2998:
DiskInfo::get_disk_devices can't handle paths which are symbolic links
vagetablechicken opened a new issue #2998: DiskInfo::get_disk_devices can't handle paths which are symbolic links
URL: https://github.com/apache/incubator-doris/issues/2998
**Describe the bug**
https://github.com/apache/incubator-doris/blob/569d0bb3af4cba51ff0e3b736ae9f360beaf90da/be/src/util/disk_info.cpp#L191-L196
Doris use get_disk_devices to find which disk the path is on.
But it can't handle the symbolic links. Doris system metrics about devices, e.g. max_disk_io_util_percent, can't be calculated.
**To Reproduce**
Steps to reproduce the behavior:
1. We have "/home/app/doris/ssd1 -> /home/ssd1/doris". It's for service isolation.
1. /proc/mounts contains "/dev/sdb1 /home/ssd1 ext4 rw,noatime,data=ordered 0 0"
1. Set storage_root_path=/home/app/doris/ssd1
1. Then DiskInfo::get_disk_devices() get no device.
**Expected behavior**
We should canonical the paths, so that the path "/home/ssd1/doris" will find the disk_name "/home/ssd1".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay closed issue #2998:
DiskInfo::get_disk_devices can't handle paths which are symbolic links
Posted by GitBox <gi...@apache.org>.
imay closed issue #2998: DiskInfo::get_disk_devices can't handle paths which are symbolic links
URL: https://github.com/apache/incubator-doris/issues/2998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org