[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #10450: ARROW-9947: [Python] High-level Python API for Parquet encryption of files.

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on a change in pull request #10450:
URL: https://github.com/apache/arrow/pull/10450#discussion_r688349345



##########
File path: python/examples/parquet_encryption/sample_vault_kms_client.py
##########
@@ -0,0 +1,164 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""A sample KmsClient implementation."""
+
+import pyarrow as pa
+
+try:
+    import pyarrow.parquet as pq
+except ImportError:
+    pq = None
+
+import requests
+import base64
+from typing import OrderedDict

Review comment:
       (it should also not be needed to use an OrderedDict here to create the table, since python dicts are now also ordered by default)

##########
File path: ci/scripts/python_wheel_macos_build.sh
##########
@@ -104,6 +105,7 @@ cmake \
     -DARROW_ORC=${ARROW_ORC} \
     -DARROW_PACKAGE_KIND="python-wheel-macos" \
     -DARROW_PARQUET=${ARROW_PARQUET} \
+    -DPARQUET_REQUIRE_ENCRYPTION=${PARQUET_REQUIRE_ENCRYPTION}

Review comment:
       This can also be checked by triggering crossbow to run the wheel tasks on the PR here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org