You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/02/26 19:05:01 UTC
Review Request 57074: Fix scheduler_framework_disconnects stats
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57074/
-----------------------------------------------------------
Review request for Aurora, Mehrdad Nurolahzade and Zameer Manji.
Bugs: AURORA-1860
https://issues.apache.org/jira/browse/AURORA-1860
Repository: aurora
Description
-------
Refactoring in r/31550 has disabled incrementing scheduler_framework_disconnects stats. This change brings it back.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 17301036e28d95ba90b3e4d8840d8a5641e49c46
src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 9bb319bb04bb386d9792c3cc0017b039e8f25044
Diff: https://reviews.apache.org/r/57074/diff/
Testing
-------
Added a check to `MesosSchedulerImplTest.testDisconnected()`. Manually verified in Vagrant by starting/stopping mesos-master and querying `/vars` endpoint.
Thanks,
Ilya Pronin
Re: Review Request 57074: Fix scheduler_framework_disconnects stats
Posted by Mehrdad Nurolahzade <me...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57074/#review166830
-----------------------------------------------------------
Ship it!
Ship It!
- Mehrdad Nurolahzade
On Feb. 26, 2017, 11:05 a.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57074/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2017, 11:05 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade and Zameer Manji.
>
>
> Bugs: AURORA-1860
> https://issues.apache.org/jira/browse/AURORA-1860
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactoring in r/31550 has disabled incrementing scheduler_framework_disconnects stats. This change brings it back.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 17301036e28d95ba90b3e4d8840d8a5641e49c46
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 9bb319bb04bb386d9792c3cc0017b039e8f25044
>
> Diff: https://reviews.apache.org/r/57074/diff/
>
>
> Testing
> -------
>
> Added a check to `MesosSchedulerImplTest.testDisconnected()`. Manually verified in Vagrant by starting/stopping mesos-master and querying `/vars` endpoint.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 57074: Fix scheduler_framework_disconnects stats
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57074/#review166899
-----------------------------------------------------------
Ship it!
Ship It!
- Reza Motamedi
On Feb. 26, 2017, 7:05 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57074/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2017, 7:05 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade and Zameer Manji.
>
>
> Bugs: AURORA-1860
> https://issues.apache.org/jira/browse/AURORA-1860
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactoring in r/31550 has disabled incrementing scheduler_framework_disconnects stats. This change brings it back.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 17301036e28d95ba90b3e4d8840d8a5641e49c46
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 9bb319bb04bb386d9792c3cc0017b039e8f25044
>
> Diff: https://reviews.apache.org/r/57074/diff/
>
>
> Testing
> -------
>
> Added a check to `MesosSchedulerImplTest.testDisconnected()`. Manually verified in Vagrant by starting/stopping mesos-master and querying `/vars` endpoint.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 57074: Fix scheduler_framework_disconnects stats
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57074/#review166913
-----------------------------------------------------------
This is now on master.
Thank you for your contribution.
- Zameer Manji
On Feb. 26, 2017, 11:05 a.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57074/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2017, 11:05 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade and Zameer Manji.
>
>
> Bugs: AURORA-1860
> https://issues.apache.org/jira/browse/AURORA-1860
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactoring in r/31550 has disabled incrementing scheduler_framework_disconnects stats. This change brings it back.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 17301036e28d95ba90b3e4d8840d8a5641e49c46
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 9bb319bb04bb386d9792c3cc0017b039e8f25044
>
> Diff: https://reviews.apache.org/r/57074/diff/
>
>
> Testing
> -------
>
> Added a check to `MesosSchedulerImplTest.testDisconnected()`. Manually verified in Vagrant by starting/stopping mesos-master and querying `/vars` endpoint.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 57074: Fix scheduler_framework_disconnects stats
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57074/#review166910
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Feb. 26, 2017, 11:05 a.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57074/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2017, 11:05 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade and Zameer Manji.
>
>
> Bugs: AURORA-1860
> https://issues.apache.org/jira/browse/AURORA-1860
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactoring in r/31550 has disabled incrementing scheduler_framework_disconnects stats. This change brings it back.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 17301036e28d95ba90b3e4d8840d8a5641e49c46
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 9bb319bb04bb386d9792c3cc0017b039e8f25044
>
> Diff: https://reviews.apache.org/r/57074/diff/
>
>
> Testing
> -------
>
> Added a check to `MesosSchedulerImplTest.testDisconnected()`. Manually verified in Vagrant by starting/stopping mesos-master and querying `/vars` endpoint.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 57074: Fix scheduler_framework_disconnects stats
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57074/#review166831
-----------------------------------------------------------
Ship it!
Master (fadfd55) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 26, 2017, 7:05 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57074/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2017, 7:05 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade and Zameer Manji.
>
>
> Bugs: AURORA-1860
> https://issues.apache.org/jira/browse/AURORA-1860
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Refactoring in r/31550 has disabled incrementing scheduler_framework_disconnects stats. This change brings it back.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 17301036e28d95ba90b3e4d8840d8a5641e49c46
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 9bb319bb04bb386d9792c3cc0017b039e8f25044
>
> Diff: https://reviews.apache.org/r/57074/diff/
>
>
> Testing
> -------
>
> Added a check to `MesosSchedulerImplTest.testDisconnected()`. Manually verified in Vagrant by starting/stopping mesos-master and querying `/vars` endpoint.
>
>
> Thanks,
>
> Ilya Pronin
>
>